fixes #488 - allow StructMeta copyFrom / deepcopyFrom / updateFrom to… #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robambalu
added
the
tag: wip
robambalu
force-pushed
the
488-struct-copy_from-update_from-should-work-on-base-types
branch
from
8729de4 to
1f8b082
Compare
robambalu
requested review from
AdamGlustein,
svatasoiu and
alexddobkin
as code owners
robambalu
removed
the
tag: wip
robambalu
force-pushed
the
488-struct-copy_from-update_from-should-work-on-base-types
branch
2 times, most recently
from
6e03b56 to
43636b7
Compare
AdamGlustein
requested changes
Mar 24, 2025
… work on base types as well Signed-off-by: Rob Ambalu <[email protected]>
robambalu
force-pushed
the
488-struct-copy_from-update_from-should-work-on-base-types
branch
from
43636b7 to
5326514
Compare
AdamGlustein
approved these changes
Mar 24, 2025
robambalu
deleted the
488-struct-copy_from-update_from-should-work-on-base-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… work on base types as well