Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request (?): Extend to sort tokens to other language? #482

Open
fredsleeve opened this issue Aug 9, 2024 · 3 comments
Open

Feature request (?): Extend to sort tokens to other language? #482

fredsleeve opened this issue Aug 9, 2024 · 3 comments

Comments

@fredsleeve
Copy link
Contributor

Currently the option "Ignore articles in title" only works for English articles. Would it be possible to extend this for further language too? E.g. for German it would be: der/die/das/ein/eine

To implement this it would also be a good idea to implemented this in an XML file here in Github, so the community could maintain this on their own.

@gemiren
Copy link
Collaborator

gemiren commented Aug 9, 2024

It's a good idea to load the tokens from an external file instead of hard coded strings in the app. Will add that. Thanks.

@fredsleeve
Copy link
Contributor Author

fredsleeve commented Aug 11, 2024

One technical aspect you should consider: Will these sort tokens work only for the set app language or over all languages? For last implementation there might be some (rare) side effects: E.g. a podcast with the title "Die Another Day" will be sorted differently because "Die" (The) is an German article. Or maybe you should consider the pdocast language (if available) to determine the sort tokens.

@gemiren
Copy link
Collaborator

gemiren commented Aug 11, 2024

Ideally the app should detect the language used for the title and then apply the applicable tokens. That can be very challenging if the title is very short or written in an informal way. Using the language of the podcast is a good workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants