-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark episode as played does not delete the download #254
Comments
Thanks very much for the bug report. Two things to check:
|
|
Since you have it set to jump to the next episode then the episode won't get marked as 100% played. The app will only delete the download after it's 100% played. |
When I press the mark played button, the episode is marked as played, the playback position is set to 100% and it is deleted. |
Let me clarify that the option 'Mark episode as played' is used for display purposes only. Episodes with playback progress over that percentage will not show up in the unplayed filter. If the app deletes download automatically when the 'Mark episode as played' percentage is reached then you may lost your download accidentally and have to redownload it. For example, assuming you were playing an episode passed this marked as played percentage. A phone call came in and the playback was paused. The download was removed! I'm sure you don't want this behavior. Considering that the app can only delete the download automatically after the episode is 100% played. |
Thanks for the explanation. I agree with this example. I'm only suggesting that the downloaded file should only be deleted when both of the following conditions are met:
|
When the playback of the episode reaches the percentage set in "mark episode as played" option and I press the jump to next episode button, the episode is marked as played, but not deleted from downloads. I think it should.
Delete the download when an episode is 100% played option is enabled.
The text was updated successfully, but these errors were encountered: