Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark episode as played does not delete the download #254

Open
vlzuykov opened this issue Jun 30, 2023 · 6 comments
Open

Mark episode as played does not delete the download #254

vlzuykov opened this issue Jun 30, 2023 · 6 comments

Comments

@vlzuykov
Copy link
Contributor

When the playback of the episode reaches the percentage set in "mark episode as played" option and I press the jump to next episode button, the episode is marked as played, but not deleted from downloads. I think it should.
Delete the download when an episode is 100% played option is enabled.

@gemiren
Copy link
Collaborator

gemiren commented Jul 1, 2023

Thanks very much for the bug report. Two things to check:

  1. In app Settings > Media player > When I press Next button, make sure it is set to 'Jump to the end'.

  2. Please make sure the playback mode is not set to either 'Repeat playlist' or 'Repeat episode'.

@vlzuykov
Copy link
Contributor Author

vlzuykov commented Jul 1, 2023

  1. I deliberately choose to have this setting set to jump to the next episode because it's easy to accidentally tap on this button. I usually use dedicated jump to the end button on the long press of the jump to next episode button.
  2. The playback mode is not set to either 'Repeat playlist' or 'Repeat episode'.

@gemiren
Copy link
Collaborator

gemiren commented Jul 1, 2023

Since you have it set to jump to the next episode then the episode won't get marked as 100% played. The app will only delete the download after it's 100% played.

@vlzuykov
Copy link
Contributor Author

vlzuykov commented Jul 1, 2023

When I press the mark played button, the episode is marked as played, the playback position is set to 100% and it is deleted.
When I press the jump to end button, the episode is marked as played, the playback position is set to 100% and it is deleted.
But when I listen to the episode for the percentage specified in the settings and press the button to go to the next episode, the episode is marked as played, the playback position remains at the one I listened to and it is not deleted.
It looks strange that the episode is marked as played and, at the same time, the playback position is not set to 100%. Is this done on purpose?

@gemiren
Copy link
Collaborator

gemiren commented Jul 1, 2023

Let me clarify that the option 'Mark episode as played' is used for display purposes only. Episodes with playback progress over that percentage will not show up in the unplayed filter.

If the app deletes download automatically when the 'Mark episode as played' percentage is reached then you may lost your download accidentally and have to redownload it. For example, assuming you were playing an episode passed this marked as played percentage. A phone call came in and the playback was paused. The download was removed! I'm sure you don't want this behavior. Considering that the app can only delete the download automatically after the episode is 100% played.

@vlzuykov
Copy link
Contributor Author

vlzuykov commented Jul 1, 2023

Thanks for the explanation. I agree with this example. I'm only suggesting that the downloaded file should only be deleted when both of the following conditions are met:

  1. Listening process has reached a certain percentage (at this stage, if the podcast listening is interrupted by an incoming call, the downloaded file will not be deleted).
  2. After that, a user manually tap on the jump to the next episode button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants