Skip to content

Update to a more recent version of rocket and to nightly-2018-07-17#1

Merged
trinity-1686a merged 1 commit into
Plume-org:plumefrom
lthms:latest-rocket-4.0
Sep 8, 2018
Merged

Update to a more recent version of rocket and to nightly-2018-07-17#1
trinity-1686a merged 1 commit into
Plume-org:plumefrom
lthms:latest-rocket-4.0

Conversation

@lthms

@lthms lthms commented Sep 8, 2018

Copy link
Copy Markdown
Contributor

This is a prerequisite for Plume-org/Plume#205

I had to update the code in order to deal with a breaking change in rocket. Tests still pass, but I would advice a careful code review nonetheless :).

With this change, I have been able to make Plume build with nightly-2018-07-17.

@codecov-io

codecov-io commented Sep 8, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1 into plume will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            plume       #1      +/-   ##
==========================================
+ Coverage   96.77%   96.78%   +0.01%     
==========================================
  Files           6        6              
  Lines        1022     1026       +4     
==========================================
+ Hits          989      993       +4     
  Misses         33       33
Impacted Files Coverage Δ
src/csrf_fairing.rs 96.13% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a1aa1e...06e14f8. Read the comment docs.

@lthms lthms force-pushed the latest-rocket-4.0 branch from 11e1a8c to 06e14f8 Compare September 8, 2018 13:25
@lthms

lthms commented Sep 8, 2018

Copy link
Copy Markdown
Contributor Author

Should be good with latest changes. Tests run just fine on my laptop, at least.

@trinity-1686a trinity-1686a merged commit 6fc55d2 into Plume-org:plume Sep 8, 2018
@lthms

lthms commented Sep 8, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants