Update to a more recent version of rocket and to nightly-2018-07-17#1
Merged
Merged
Conversation
3 tasks
Codecov Report
@@ Coverage Diff @@
## plume #1 +/- ##
==========================================
+ Coverage 96.77% 96.78% +0.01%
==========================================
Files 6 6
Lines 1022 1026 +4
==========================================
+ Hits 989 993 +4
Misses 33 33
Continue to review full report at Codecov.
|
11e1a8c to
06e14f8
Compare
Contributor
Author
|
Should be good with latest changes. Tests run just fine on my laptop, at least. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for Plume-org/Plume#205
I had to update the code in order to deal with a breaking change in
rocket. Tests still pass, but I would advice a careful code review nonetheless :).With this change, I have been able to make Plume build with
nightly-2018-07-17.