Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wind Charge causes fake explosion logs in CoreProtect #696

Open
DereC4 opened this issue Jan 9, 2025 · 6 comments · May be fixed by #701
Open

Wind Charge causes fake explosion logs in CoreProtect #696

DereC4 opened this issue Jan 9, 2025 · 6 comments · May be fixed by #701

Comments

@DereC4
Copy link

DereC4 commented Jan 9, 2025

Wind charge detonation causes blocks that are currently still there (unbroken) to be logged as broken in CoreProtect

This can be observed heavily in trial chambers when multiple breezes spawn
@quintindunn
Copy link

Same issue here, seems like an easy fix.

@quintindunn
Copy link

Furthermore, blocks that actually get broken by wind charges (chorus flower, and decorated pots), don't get logged.

@quintindunn
Copy link

quintindunn commented Jan 11, 2025 •
edited
Loading

This was fixed in 3e8083b, just latest release doesn't have it, you'd have to build from source.

@DereC4
Copy link
Author

DereC4 commented Jan 11, 2025

Do trapdoor interactions get properly logged? I haven't been able to check yet

@quintindunn
Copy link

Doesn't seem like it, decorated pots don't log breaking either. I'm working on a fix right now for decorated pots, I'll see if I can get the other interactions wind charges do working as well.

@quintindunn
Copy link

This was fixed in 3e8083b, just latest release doesn't have it, you'd have to build from source.

This fix also doesn't work for wind charges summoned by a breeze, as these are counted as the "BREEZE_WIND_CHARGE" entity.

@quintindunn quintindunn linked a pull request Jan 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix logging caused by wind charges quintindunn/CoreProtect
2 participants
@DereC4 @quintindunn