fix for GsdkConfig #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
force-pushed
the
initcontainergsdkfix
branch
from
205b42e
to
53ce46c
Compare
dgkanatsios
force-pushed
the
initcontainergsdkfix
branch
from
53ce46c
to
3837c48
Compare
dgkanatsios
force-pushed
the
initcontainergsdkfix
branch
from
3837c48
to
69bab52
Compare
khaines
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating the Go GSDK and testing with the LocalMultiplayerAgent, we found out that the GsdkConfig.GamePorts field should actually be map[string]string instead of map[string]int. We verified it by checking some MPS VMs as well. As we copied this type on the Go GSDK from the one here in the thundernetes repo, we should make that change here as well. Created #57 to create unit tests for initcontainer as well.