allocator draft #28
Merged
allocator draft #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
reviewed
Oct 14, 2021
dgkanatsios
reviewed
Oct 14, 2021
tools/allocator/main.go
Outdated
| "-o","jsonpath='{.status.loadBalancer.ingress[0].ip}'"); | ||
| var ip string; | ||
| reqBody, err := json.Marshal(map[string] string { | ||
| "buildID": "85ffe8da-c82f-4035-86c5-9d2b5f42d6f6", |
There was a problem hiding this comment.
these should be updateable by the user
dgkanatsios
reviewed
Oct 14, 2021
tools/allocator/main.go
Outdated
|
|
||
| if len(args) <= 1 { | ||
| fmt.Println("Usage of the allocator tool"); | ||
| fmt.Println("\tallocate #Initialize a server with the given paramaters"); |
There was a problem hiding this comment.
Can we specify that the valid input for this is (1)?
dgkanatsios
reviewed
Oct 15, 2021
dgkanatsios
reviewed
Oct 15, 2021
tools/allocator/main.go
Outdated
| args := os.Args; | ||
|
|
||
| if len(args) == 1 { | ||
| fmt.Println("Usage of the allocator tool (is highly recommended to have"+ |
There was a problem hiding this comment.
I'd say its required, not just recommended
There was a problem hiding this comment.
typo: "it" is required
dgkanatsios
reviewed
Oct 15, 2021
tools/allocator/main.go
Outdated
| @@ -0,0 +1,146 @@ | |||
| package main; | |||
There was a problem hiding this comment.
go.mod is missing, did you run go mod init? #Resolved
dgkanatsios
reviewed
Oct 15, 2021
tools/allocator/main.go
Outdated
| @@ -0,0 +1,146 @@ | |||
| package main; | |||
There was a problem hiding this comment.
also, any chance you can add a README.md with some basic instructions?
dgkanatsios
reviewed
Oct 15, 2021
dgkanatsios
reviewed
Oct 15, 2021
dgkanatsios
reviewed
Oct 16, 2021
tools/allocator/README.md
Outdated
| Thanks for using the allocator tool for thundernetes. To use it: | ||
| - `kubectl` is required to be in $PATH. for more information, please refer to the following [guide](https://kubernetes.io/docs/tasks/tools/#kubectl) | ||
| - Compile the main.go file (optional to provide a meaningful name like allocator, thunderallocator or something similar). | ||
| - Once you the executable, you can: |
dgkanatsios
reviewed
Oct 16, 2021
tools/allocator/README.md
Outdated
|
|
||
| Thanks for using the allocator tool for thundernetes. To use it: | ||
| - `kubectl` is required to be in $PATH. for more information, please refer to the following [guide](https://kubernetes.io/docs/tasks/tools/#kubectl) | ||
| - Compile the main.go file (optional to provide a meaningful name like allocator, thunderallocator or something similar). |
There was a problem hiding this comment.
Add go run main.go to compile it
|
Fixes #14 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this branch will be uploaded the proposed changes to the thundernetes allocator tool