Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for windows containers #241

Merged
merged 22 commits into from
May 12, 2022
Merged

Added support for windows containers #241

merged 22 commits into from
May 12, 2022

Conversation

javier-op
Copy link
Contributor

Implements #8

@javier-op javier-op marked this pull request as ready for review May 11, 2022 14:56
@dgkanatsios
Copy link
Collaborator

  It("should attach init container", func() {

can we add a test for Windows? It would make a difference if we (by mistake) change one of the fieldnames etc.


Refers to: pkg/operator/controllers/utilities_test.go:137 in 4040156. [](commit_id = 4040156, deletion_comment = False)

Makefile Show resolved Hide resolved
Copy link
Collaborator

@dgkanatsios dgkanatsios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@javier-op javier-op merged commit 86a8512 into main May 12, 2022
@javier-op javier-op deleted the windows_containers branch May 12, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants