Simpifying portsToExpose on CRD #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgkanatsios
added
the
area/user-experiences
dgkanatsios
force-pushed
the
portstoexpose
branch
9 times, most recently
from
c1f6a94
to
ce6a27b
Compare
dgkanatsios
force-pushed
the
portstoexpose
branch
5 times, most recently
from
4677ff3
to
e3ab4e5
Compare
dgkanatsios
force-pushed
the
portstoexpose
branch
from
e3ab4e5
to
104c3bb
Compare
javier-op
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the CRDs by removing the need to specify containerName/portName for the portsToExpose, leaving just an array of int32.
Moreover, during testing we discovered an issue where the PodSpec was not DeepCopied(), which led to interesting sideeffects.
This is going to be a breaking change and will require 2 more PRs.