New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data race during testing on NodeAgent tests #325

Closed

dgkanatsios opened this issue Jul 20, 2022 · 0 comments · Fixed by #354

Assignees

Labels

area/tests

Collaborator

dgkanatsios commented Jul 20, 2022

A repro here: https://github.com/PlayFab/thundernetes/runs/7438045505?check_suite_focus=true

Occasionally, there will be a data race when running the NodeAgent tests. We suspect this happens because

we manually set the nowFunc method to mock time https://github.com/PlayFab/thundernetes/blob/main/cmd/nodeagent/nodeagentmanager_test.go#L639 and, at the same time,
we read it on the (periodically running) HeartbeatTimeChecker on https://github.com/PlayFab/thundernetes/blob/main/cmd/nodeagent/nodeagentmanager.go#L118

This failure cannot repro locally, since (we think) the tests run before the HeartbeatTimeChecker has a chance to execute.

dgkanatsios added the area/tests label

dgkanatsios assigned javier-op

javier-op mentioned this issue

Fix for data race in heartBeatTimeChecker tests #354

Merged

javier-op closed this as completed in #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment