Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use watches for the sidecars #25

Closed
dgkanatsios opened this issue Oct 14, 2021 · 0 comments · Fixed by #31
Closed

Use watches for the sidecars #25

dgkanatsios opened this issue Oct 14, 2021 · 0 comments · Fixed by #31
Assignees
@dgkanatsios
Labels
enhancement New feature or request

Comments

@dgkanatsios
Copy link
Collaborator

Currently sidecar is notified for a change in the allocation state by having its HTTP server accessible in the cluster. We should change to use a Kubernetes watch to prevent security issues. Proposed workflow:

  1. sidecar starts
  2. sidecar creates a Watch on the Kubernetes API server for the particular CRD instance
  3. when the sidecar/GameServer gets allocated (transitions to Active), we kill the Watch to decrease pressure on the Kubernetes API server.
@dgkanatsios dgkanatsios added the enhancement New feature or request label Oct 14, 2021
@dgkanatsios dgkanatsios self-assigned this Oct 14, 2021
This was referenced Oct 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgkanatsios dgkanatsios

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

switching to watches for allocation PlayFab/thundernetes
1 participant
@dgkanatsios