Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for href code wrapping in cells #1785

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

rocco8773
Copy link
Member

Attempt to resolve #1784

This updates our CSS to prevent href code styled blocks from freely wrapping.

@rocco8773 rocco8773 requested a review from a team as a code owner November 2, 2022 03:16
@rocco8773 rocco8773 requested review from namurphy and removed request for a team November 2, 2022 03:16
@github-actions github-actions bot added the docs PlasmaPy Docs at http://docs.plasmapy.org label Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Thank you for contributing to PlasmaPy! The project's future depends deeply on contributors like you, so we deeply appreciate it! 🌱 The following checklist will be used by the code reviewer to help guide the code review process.

  • Overall
    • Does the PR do what it intends to do?
    • Except for very minor changes, is a changelog entry included and consistent with the changelog guide?
    • Are the continuous integration checks passing? (Most linter problems can be automagically fixed by commenting on this PR with pre-commit.ci autofix.)
  • Code
    • Is new/updated code understandable and consistent with the coding guide?
    • Are there ways to greatly simplify the implementation?
    • Are there any large functions that should be split up into shorter functions?
  • Tests
    • Are tests added/updated as required, and consistent with the testing guide?
    • Are the tests understandable?
    • Do the tests cover all important cases?
  • Docs
    • Are docs added/updated as required, and consistent with the doc guide?
    • Are the docs understandable?
    • Do the docs show up correctly in the preview, including Jupyter notebooks?

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 98.36% // Head: 98.36% // No change to project coverage 👍

Coverage data is based on head (a3ce8d5) compared to base (7fdbc50).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1785   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files          86       86           
  Lines        8176     8176           
=======================================
  Hits         8042     8042           
  Misses        134      134           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rocco8773
Copy link
Member Author

This does appear to fix #1784

Copy link
Member

@StanczakDominik StanczakDominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get it in, then! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs PlasmaPy Docs at http://docs.plasmapy.org no changelog entry needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS issues with todays release of sphinx_rtd_theme==1.1.0
2 participants