Skip to content

Feature/add giftfund#1592

Merged
mariahosfeld merged 9 commits into
developfrom
feature/add-giftfund
Oct 31, 2022
Merged

Feature/add giftfund#1592
mariahosfeld merged 9 commits into
developfrom
feature/add-giftfund

Conversation

@prachigarg19

Copy link
Copy Markdown
Collaborator

No description provided.

@vercel

vercel Bot commented Oct 25, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
planet-webapp ✅ Ready (Inspect) Visit Preview Oct 31, 2022 at 1:15PM (UTC)

@sagararyal

sagararyal commented Oct 25, 2022

Copy link
Copy Markdown
Member

1. Add translation
2. Add box shadow
@mariahosfeld

Copy link
Copy Markdown
Contributor

When checking with a PlanetCash account without a GiftFund, the menu item is still visible. In such cases it needs to be hidden.

@mariahosfeld

Copy link
Copy Markdown
Contributor

Functionality now works as expected.

@Shreyaschorge Shreyaschorge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jst a minor addition.

Comment thread pages/profile/giftfund/index.tsx
@mariahosfeld

Copy link
Copy Markdown
Contributor

If I create a new Gift Fund for an account that did not have one, after a refresh I am able to see the menu item but always get redirected to /profile.

@mariahosfeld

Copy link
Copy Markdown
Contributor

Now the functionality works as expected.

@Shreyaschorge Shreyaschorge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariahosfeld mariahosfeld merged commit 0d2da63 into develop Oct 31, 2022
@mariahosfeld mariahosfeld deleted the feature/add-giftfund branch October 31, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants