Skip to content

Feature/max density#1561

Merged
mariahosfeld merged 17 commits into
developfrom
feature/maxDensity
Oct 6, 2022
Merged

Feature/max density#1561
mariahosfeld merged 17 commits into
developfrom
feature/maxDensity

Conversation

@sunilsabatp

@sunilsabatp sunilsabatp commented Sep 3, 2022

Copy link
Copy Markdown
Contributor

to do : max planting density text field for restoration project

steps: 1. log in as RO and go to project
2.create or edit the project (only restoration)
3.then go to detail analysis and fill the maximum planting density

for Frontend view of single project visit to : /projectId to check planting density info based on condition

@vercel

vercel Bot commented Sep 3, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
planet-webapp ✅ Ready (Inspect) Visit Preview Oct 6, 2022 at 6:25AM (UTC)

@norbertschuler norbertschuler left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM

@mariahosfeld mariahosfeld left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaxPlantingDensity should currently not be mandatory.

@prachigarg19

Copy link
Copy Markdown
Collaborator

@sunilsabatp Why is inline styling being applied at multiple places in DetailedAnalysis component?
Also, could you resolve the conflicts?
I'm not able to figure out how to view max density on the frontend. Could you guide me on the same?

@sunilsabatp

Copy link
Copy Markdown
Contributor Author

@sunilsabatp Why is inline styling being applied at multiple places in DetailedAnalysis component? Also, could you resolve the conflicts? I'm not able to figure out how to view max density on the frontend. Could you guide me on the same?

sure

@prachigarg19 prachigarg19 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me.

@mariahosfeld mariahosfeld left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works for me, but in German the layout in the project details is broken. It does not break correctly and therefore cuts of part of the headline.
This is how it looks
grafik
This is what it should look like
grafik

@mariahosfeld

Copy link
Copy Markdown
Contributor

Functionality works correctly as well as the layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change "planting_density" from 1 value to 2 values (a range)

4 participants