Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Vulkan shader codegen tests fail #3276

Open
DDoS opened this issue Sep 6, 2024 · 1 comment
Open

Some Vulkan shader codegen tests fail #3276

DDoS opened this issue Sep 6, 2024 · 1 comment

Comments

@DDoS
Copy link

DDoS commented Sep 6, 2024

I get this error diff for testHdStCodeGen_Vulkan_Curves_Bindless and testHdStCodeGen_Vulkan_Curves_Indirect.

2633a2634,2635
>     color.rgb = ApplyColorOverrides(color).rgb;
> 
2642c2644,2646
<     color = ShadingTerminal(vec4(Peye, 1), Neye, color, patchCoord);
---
>     color.rgb = mix(color.rgb,
>                     ShadingTerminal(vec4(Peye, 1), Neye, color, patchCoord).rgb,
>                     GetLightingBlendAmount());

I cannot find the original glslfx for the baseline code. The output shader is annotated with // line 1176 "basisCurves.glslfx", which looks like the output shader, not the baseline. I searched the code base for any other occurrence and found nothing. Either the baseline is wrong, or I'm not understanding something about the shader codegen.

Ran using Lavapipe on macOS.

@jesschimein
Copy link

Filed as internal issue #USD-10088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants