Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Components] google_ad_manager #14555

Closed
pipedream-component-development opened this issue Nov 5, 2024 · 7 comments · Fixed by #14672
Closed

[Components] google_ad_manager #14555

pipedream-component-development opened this issue Nov 5, 2024 · 7 comments · Fixed by #14672
Assignees
@jcortes
Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@pipedream-component-development
Copy link
Collaborator

pipedream-component-development commented Nov 5, 2024 •
edited by jcortes
Loading

google_ad_manager

URLs

Actions

create-report

Prompt

Create a report object.
@vunguyenhung vunguyenhung added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Nov 7, 2024
@jcortes jcortes self-assigned this Nov 15, 2024
@jcortes jcortes moved this from To Do to Doing in Component (Source and Action) Backlog Nov 15, 2024
@jcortes jcortes mentioned this issue Nov 18, 2024
Merged
@jcortes jcortes moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Nov 18, 2024
@michelle0927 michelle0927 moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Nov 18, 2024
@vunguyenhung vunguyenhung moved this from Ready for QA to Changes Required in Component (Source and Action) Backlog Nov 19, 2024
@vunguyenhung
Copy link
Collaborator

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Components-google_ad_manager-142bf548bb5e8112b314dde59bbc3615

@jcortes
Copy link
Collaborator

jcortes commented Nov 19, 2024

HI @vunguyenhung please try again with latest push, thanks!

@jcortes jcortes moved this from Changes Required to Ready for QA in Component (Source and Action) Backlog Nov 19, 2024
@vunguyenhung
Copy link
Collaborator

I'm waiting for Google to approve my Google Ad Manager account to continue testing this
image

@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Nov 21, 2024
@vunguyenhung
Copy link
Collaborator

vunguyenhung commented Nov 21, 2024 •
edited
Loading

Google has not approved my application. I'll move this to ready for release in the mean time for user to use.

@vunguyenhung vunguyenhung moved this from In QA to Ready for Release in Component (Source and Action) Backlog Nov 21, 2024
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Components-google_ad_manager-142bf548bb5e8112b314dde59bbc3615

@github-project-automation github-project-automation bot moved this from Ready for Release to Done in Component (Source and Action) Backlog Nov 21, 2024
@malexanderlim
Copy link
Contributor

@vunguyenhung , can you test this by creating a test network in your account?
https://developers.google.com/ad-manager/api/beta/test-networks

@vunguyenhung
Copy link
Collaborator

vunguyenhung commented Nov 22, 2024 •
edited
Loading

Thanks @malexanderlim, I've created a test network and verified it. Updated the test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcortes jcortes

Labels
triaged For maintainers: This issue has been triaged by a Pipedream employee
Projects
Component (Source and Action) Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Components] google_ad_manager - create report action component jcortes/pipedream
4 participants
@jcortes @vunguyenhung @malexanderlim @pipedream-component-development