Skip to content

Commit 0271331

Browse files
author
Manuel Cervantes
committed
Updated
1 parent 531b2e7 commit 0271331

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

CONTRIBUTING.md

+8-4
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,26 @@
33
Please read these guidelines before contributing code.
44

55
## :nut_and_bolt: Setting up the development environment
6+
67
- Fork and clone the repository
78
- `npm install`
89
- `npm run watch`
910
- To update js and css files, use the `src` folder: src/js/glightbox.js and src/postcss/glightbox.css These files will be compiled automatically with every change to the `dist` folder (do not modify the dist files directly)
1011

1112
## :bug: Fixing a Bug
12-
When fixing a bug please make sure to test it in several browsers including ie11. If you are not able to do so, mention that in a PR comment, so other contributors can do it.
13+
14+
When fixing a bug please make sure to test it in several browsers including ie11. If you are not able to do so, mention that in a PR comment, so other contributors can do it. once your code is working please run the following command "eslint src/js" to verify that your code is following the same coding standards
1315

1416
## :tada: Proposing a Change
15-
When implementing a feature please create an issue first explaining your idea and asking whether there's need for such a feature.
16-
Remember the script's core philosophy is to stay simple and minimal, doing one thing and doing it right.
17+
18+
When implementing a feature please create an issue first explaining your idea and asking whether there's need for such a feature. Remember the script's core philosophy is to stay simple and minimal, doing one thing and doing it right.
1719

1820
## :pencil: Before you open a Pull Request
19-
- Follow Git best practices (especially use meaningful commit messages).
21+
2022
- Follow the same conding style.
23+
- Run eslint to verify your code, run the following command "eslint src/js" and fix any error you find in your code
2124
- **DO NOT** commit changes in the dist directory, this files are created automatically.
25+
- Follow Git best practices (especially use meaningful commit messages).
2226
- Describe thoroughly you work in a PR comment.
2327
- Be patient and understanding. It's a side project, done in free time.
2428

0 commit comments

Comments
 (0)