diff --git a/documentation-support/src/main/java/tech/picnic/errorprone/documentation/BugPatternExtractor.java b/documentation-support/src/main/java/tech/picnic/errorprone/documentation/BugPatternExtractor.java index 4dd9c1af65..4c45e0697a 100644 --- a/documentation-support/src/main/java/tech/picnic/errorprone/documentation/BugPatternExtractor.java +++ b/documentation-support/src/main/java/tech/picnic/errorprone/documentation/BugPatternExtractor.java @@ -85,7 +85,7 @@ private static ImmutableList getSuppressionAnnotations(ClassTree tree) { .collect(toImmutableList()); } - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Type safety is validated, but a caller responsibility. */) private static T doCast(AnnotationValue value, Class target) { verify(target.isInstance(value), "Value '%s' is not of type '%s'", value, target); return (T) value; diff --git a/documentation-support/src/main/java/tech/picnic/errorprone/documentation/DocumentationGeneratorTaskListener.java b/documentation-support/src/main/java/tech/picnic/errorprone/documentation/DocumentationGeneratorTaskListener.java index 24659018d4..3456ce8556 100644 --- a/documentation-support/src/main/java/tech/picnic/errorprone/documentation/DocumentationGeneratorTaskListener.java +++ b/documentation-support/src/main/java/tech/picnic/errorprone/documentation/DocumentationGeneratorTaskListener.java @@ -26,7 +26,7 @@ */ // XXX: Find a better name for this class; it doesn't generate documentation per se. final class DocumentationGeneratorTaskListener implements TaskListener { - @SuppressWarnings({"rawtypes", "unchecked"}) + @SuppressWarnings({"rawtypes", "unchecked"} /* Unbounded wildcard type introduction is safe. */) private static final ImmutableList> EXTRACTORS = (ImmutableList) ImmutableList.copyOf( diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJEnumerableRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJEnumerableRules.java index f66109160e..16207f149d 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJEnumerableRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJEnumerableRules.java @@ -31,7 +31,7 @@ void before( } @BeforeTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) void before( ObjectEnumerableAssert enumAssert, @Matches(IsEmpty.class) Iterable emptyIterable) { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJRules.java index 1be790bfdc..d6f3f16cc3 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJRules.java @@ -169,7 +169,7 @@ OptionalLongAssert after(OptionalLong optional, long expected) { static final class ObjectEnumerableContainsOneElement { @BeforeTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ObjectEnumerableAssert before(ObjectEnumerableAssert iterAssert, T element) { return Refaster.anyOf( iterAssert.containsAnyOf(element), @@ -178,7 +178,7 @@ ObjectEnumerableAssert before(ObjectEnumerableAssert iterAssert, T e } @AfterTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ObjectEnumerableAssert after(ObjectEnumerableAssert iterAssert, T element) { return iterAssert.contains(element); } @@ -186,13 +186,13 @@ ObjectEnumerableAssert after(ObjectEnumerableAssert iterAssert, T el static final class ObjectEnumerableDoesNotContainOneElement { @BeforeTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ObjectEnumerableAssert before(ObjectEnumerableAssert iterAssert, T element) { return iterAssert.doesNotContainSequence(element); } @AfterTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ObjectEnumerableAssert after(ObjectEnumerableAssert iterAssert, T element) { return iterAssert.doesNotContain(element); } @@ -200,14 +200,14 @@ ObjectEnumerableAssert after(ObjectEnumerableAssert iterAssert, T el static final class ObjectEnumerableContainsExactlyOneElement { @BeforeTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ObjectEnumerableAssert before( ObjectEnumerableAssert iterAssert, @NotMatches(IsArray.class) T element) { return iterAssert.containsExactlyInAnyOrder(element); } @AfterTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ObjectEnumerableAssert after(ObjectEnumerableAssert iterAssert, T element) { return iterAssert.containsExactly(element); } diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableEnumSetRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableEnumSetRules.java index b7b40af650..ff4d45ffd0 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableEnumSetRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ImmutableEnumSetRules.java @@ -88,7 +88,7 @@ ImmutableSet before(T e1) { } @AfterTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ImmutableSet after(T e1) { return Sets.immutableEnumSet(e1); } @@ -110,7 +110,7 @@ ImmutableSet before(T e1, T e2) { } @AfterTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ImmutableSet after(T e1, T e2) { return Sets.immutableEnumSet(e1, e2); } @@ -133,7 +133,7 @@ ImmutableSet before(T e1, T e2, T e3) { } @AfterTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ImmutableSet after(T e1, T e2, T e3) { return Sets.immutableEnumSet(e1, e2, e3); } @@ -156,7 +156,7 @@ ImmutableSet before(T e1, T e2, T e3, T e4) { } @AfterTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ImmutableSet after(T e1, T e2, T e3, T e4) { return Sets.immutableEnumSet(e1, e2, e3, e4); } @@ -179,7 +179,7 @@ ImmutableSet before(T e1, T e2, T e3, T e4, T e5) { } @AfterTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ImmutableSet after(T e1, T e2, T e3, T e4, T e5) { return Sets.immutableEnumSet(e1, e2, e3, e4, e5); } @@ -200,7 +200,7 @@ ImmutableSet before(T e1, T e2, T e3, T e4, T e5, T e6) { } @AfterTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) ImmutableSet after(T e1, T e2, T e3, T e4, T e5, T e6) { return Sets.immutableEnumSet(e1, e2, e3, e4, e5, e6); } diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java index 10fa10ebdf..a214641756 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/MockitoRules.java @@ -67,7 +67,7 @@ Object after(InvocationOnMock invocation, int i) { static final class InvocationOnMockGetArgumentsWithTypeParameter { @BeforeTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Cast is presumed safe in matched context. */) T before(InvocationOnMock invocation, int i) { return Refaster.anyOf( invocation.getArgument(i, Refaster.clazz()), (T) invocation.getArgument(i)); diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java index 6c9dcd00f1..88aa96c8e3 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/ReactorRules.java @@ -2345,7 +2345,7 @@ StepVerifier after(StepVerifier stepVerifier) { /** Don't unnecessarily have {@link StepVerifier.Step} expect no elements. */ static final class StepVerifierStepIdentity { @BeforeTemplate - @SuppressWarnings("unchecked") + @SuppressWarnings("unchecked" /* Safe generic array type creation. */) StepVerifier.Step before( StepVerifier.Step step, @Matches(IsEmpty.class) Iterable iterable) { return Refaster.anyOf( diff --git a/error-prone-utils/src/main/java/tech/picnic/errorprone/utils/MoreTypes.java b/error-prone-utils/src/main/java/tech/picnic/errorprone/utils/MoreTypes.java index d14e555c28..8291f5422c 100644 --- a/error-prone-utils/src/main/java/tech/picnic/errorprone/utils/MoreTypes.java +++ b/error-prone-utils/src/main/java/tech/picnic/errorprone/utils/MoreTypes.java @@ -114,7 +114,7 @@ public static Supplier subOf(Supplier type) { } /** - * Creates an unbound wildcard type ({@code ?}). + * Creates an unbounded wildcard type ({@code ?}). * * @return A supplier which returns the described type. */ diff --git a/pom.xml b/pom.xml index 2e63534d09..89486b180b 100644 --- a/pom.xml +++ b/pom.xml @@ -202,7 +202,7 @@ 1.11.0 ${version.error-prone-orig} ${version.error-prone-orig}-picnic-1 - 2.43.0 + 2.44.0 21 3.9.11 2.2.5