diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJDurationRules.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJDurationRules.java index 69424e4960..a92878da42 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJDurationRules.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refasterrules/AssertJDurationRules.java @@ -112,11 +112,14 @@ AbstractDurationAssert after(Duration duration) { } } - // XXX: Once we build against JDK 18+, update this rule to also rewrite - // `assertThat(duration.isPositive()).isTrue()` static final class AssertThatIsPositive { @BeforeTemplate - AbstractDurationAssert before(Duration duration) { + AbstractBooleanAssert before(Duration duration) { + return assertThat(duration.isPositive()).isTrue(); + } + + @BeforeTemplate + AbstractDurationAssert before2(Duration duration) { return assertThat(duration).isGreaterThan(Duration.ZERO); } diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/AssertJDurationRulesTestInput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/AssertJDurationRulesTestInput.java index 371459e895..3642a9d209 100644 --- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/AssertJDurationRulesTestInput.java +++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/AssertJDurationRulesTestInput.java @@ -5,7 +5,6 @@ import com.google.common.collect.ImmutableSet; import java.time.Duration; import org.assertj.core.api.AbstractAssert; -import org.assertj.core.api.AbstractDurationAssert; import tech.picnic.errorprone.refaster.test.RefasterRuleCollectionTestCase; final class AssertJDurationRulesTest implements RefasterRuleCollectionTestCase { @@ -39,8 +38,10 @@ final class AssertJDurationRulesTest implements RefasterRuleCollectionTestCase { assertThat(Duration.ofMillis(1)).isEqualTo(Duration.ZERO)); } - AbstractDurationAssert testAssertThatIsPositive() { - return assertThat(Duration.ofMillis(0)).isGreaterThan(Duration.ZERO); + ImmutableSet> testAssertThatIsPositive() { + return ImmutableSet.of( + assertThat(Duration.ofMillis(0).isPositive()).isTrue(), + assertThat(Duration.ofMillis(1)).isGreaterThan(Duration.ZERO)); } ImmutableSet> testAssertThatIsNegative() { diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/AssertJDurationRulesTestOutput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/AssertJDurationRulesTestOutput.java index 17670cec9e..3aa3e8c860 100644 --- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/AssertJDurationRulesTestOutput.java +++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refasterrules/AssertJDurationRulesTestOutput.java @@ -5,7 +5,6 @@ import com.google.common.collect.ImmutableSet; import java.time.Duration; import org.assertj.core.api.AbstractAssert; -import org.assertj.core.api.AbstractDurationAssert; import tech.picnic.errorprone.refaster.test.RefasterRuleCollectionTestCase; final class AssertJDurationRulesTest implements RefasterRuleCollectionTestCase { @@ -38,8 +37,10 @@ final class AssertJDurationRulesTest implements RefasterRuleCollectionTestCase { assertThat(Duration.ofMillis(0)).isZero(), assertThat(Duration.ofMillis(1)).isZero()); } - AbstractDurationAssert testAssertThatIsPositive() { - return assertThat(Duration.ofMillis(0)).isPositive(); + ImmutableSet> testAssertThatIsPositive() { + return ImmutableSet.of( + assertThat(Duration.ofMillis(0)).isPositive(), + assertThat(Duration.ofMillis(1)).isPositive()); } ImmutableSet> testAssertThatIsNegative() {