Skip to content

Commit 75a8d4c

Browse files
authored
Apply clang-tidy suggestions to std::move certain variables (#228)
1 parent 787f7fb commit 75a8d4c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

generate_parameter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
#include <sstream>
1515
#include <string>
1616
#include <type_traits>
17+
#include <utility>
1718
#include <vector>
1819

1920
#include <fmt/core.h>
@@ -105,7 +106,7 @@ struct StackParams {
105106

106107
ParamListener(const std::shared_ptr<rclcpp::node_interfaces::NodeParametersInterface>& parameters_interface,
107108
rclcpp::Logger logger, std::string const& prefix = "") {
108-
logger_ = logger;
109+
logger_ = std::move(logger);
109110
prefix_ = prefix;
110111
if (!prefix_.empty() && prefix_.back() != '.') {
111112
prefix_ += ".";
@@ -210,7 +211,7 @@ struct StackParams {
210211
private:
211212
void update_internal_params(Params updated_params) {
212213
std::lock_guard<std::mutex> lock(mutex_);
213-
params_ = updated_params;
214+
params_ = std::move(updated_params);
214215
}
215216

216217
std::string prefix_;

0 commit comments

Comments
 (0)