Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use WPILib Alert API for Camera Disconnection #1798

Open
Gold872 opened this issue Mar 3, 2025 · 3 comments · May be fixed by #1799
Open

Ability to use WPILib Alert API for Camera Disconnection #1798

Gold872 opened this issue Mar 3, 2025 · 3 comments · May be fixed by #1799
Labels
enhancement New feature or request

Comments

@Gold872
Copy link

Gold872 commented Mar 3, 2025

Similar to wpilibsuite/allwpilib#7840

It would be very useful for pre-match checking (and post-match debugging) to have an alert for whether or not the camera is disconnected. Last season (2024) my team had an alert that updated whenever a camera was disconnected, and it was very useful and even prevented issues before playoff matches.

@Gold872 Gold872 added the enhancement New feature or request label Mar 3, 2025
@mcm001
Copy link
Contributor

mcm001 commented Mar 3, 2025

Doesn't seem hard to hook into our current camera stream disconnected logic. Plz pr it :))))))

@Gold872
Copy link
Author

Gold872 commented Mar 3, 2025

Plz pr it :))))))

I'll get back to you within 5-7 business days

Also if I PR it a translation to at least one non-java language will be appreciated

@Gold872
Copy link
Author

Gold872 commented Mar 3, 2025

camera stream disconnected logic

I'm assuming you're referring to the timesync disconnection warning. My one concern with this is the timeout on that is 5 seconds, which is quite high. Something like 0.5 seconds (like the heartbeats) is more desirable, but I don't think it makes a ton of sense to use different time sources between DriverStation.reportWarning() and the WPILib Alerts

@Gold872 Gold872 linked a pull request Mar 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants