revert changing signature of dematerialize

Author: remonh87

example/lib/src/ui/device_detail/characteristic_interaction_dialog.dart

@@ -135,6 +135,10 @@ class _CharacteristicInteractionDialogState
               border: OutlineInputBorder(),
               labelText: 'Value',
             ),
+            keyboardType: TextInputType.numberWithOptions(
+              decimal: true,
+              signed: false,
+            ),
           ),
         ),
         Row(

lib/src/connected_device_operation.dart

@@ -45,7 +45,7 @@ class ConnectedDeviceOperationImpl implements ConnectedDeviceOperation {
   Future<List<int>> readCharacteristic(QualifiedCharacteristic characteristic) {
     final specificCharacteristicValueStream = characteristicValueStream
         .where((update) => update.characteristic == characteristic)
-        .map((update) => update.result.dematerialize()!);
+        .map((update) => update.result.dematerialize());
 
     return _controller
         .readCharacteristic(characteristic)

lib/src/converter/protobuf_converter.dart

@@ -138,7 +138,7 @@ class ProtobufConverterImpl implements ProtobufConverter {
     return WriteCharacteristicInfo(
       characteristic: qualifiedCharacteristicFrom(message.characteristic),
       result: resultFrom(
-        getValue: () {},
+        getValue: () => Unit(),
         failure: genericFailureFrom(
           hasFailure: message.hasFailure(),
           getFailure: () => message.failure,

lib/src/device_scanner.dart

@@ -61,7 +61,7 @@ class DeviceScannerImpl implements DeviceScanner {
 
     final scanRepeater = Repeater(
       onListenEmitFrom: () =>
-          _scanStream.map((scan) => scan.result.dematerialize()!).handleError(
+          _scanStream.map((scan) => scan.result.dematerialize()).handleError(
         (Object e, StackTrace s) {
           if (!completer.isCompleted) {
             completer.completeError(e, s);

lib/src/model/result.dart

@@ -12,8 +12,8 @@ class Result<Value, Failure> {
         _value = null; // ignore: avoid_field_initializers_in_const_classes
 
   /// Provides the value in case of success or throws [Exception] in case of failure.
-  Value? dematerialize() => iif(
-        success: (value) => value,
+  Value dematerialize() => iif(
+        success: (value) => value!,
         failure: (failure) {
           if (failure is Exception && failure != null) {
             throw failure;
@@ -24,8 +24,8 @@ class Result<Value, Failure> {
       );
 
   /// Execute specific actions on success and on failure.
-  T? iif<T>(
-      {required T? Function(Value? value) success,
+  T iif<T>(
+      {required T Function(Value? value) success,
       required T Function(Failure? failure) failure}) {
     assert(_value == null || _failure == null);
 

lib/src/model/write_characteristic_info.dart

@@ -1,12 +1,13 @@
 import 'package:flutter_reactive_ble/src/model/generic_failure.dart';
 import 'package:flutter_reactive_ble/src/model/qualified_characteristic.dart';
 import 'package:flutter_reactive_ble/src/model/result.dart';
+import 'package:flutter_reactive_ble/src/model/unit.dart';
 import 'package:meta/meta.dart';
 
 @immutable
 class WriteCharacteristicInfo {
   final QualifiedCharacteristic characteristic;
-  final Result<void, GenericFailure<WriteCharacteristicFailure>?> result;
+  final Result<Unit, GenericFailure<WriteCharacteristicFailure>?> result;
 
   const WriteCharacteristicInfo({
     required this.characteristic,

test/connected_device_operation_test.dart

@@ -5,6 +5,7 @@ import 'package:flutter_reactive_ble/src/connected_device_operation.dart';
 import 'package:flutter_reactive_ble/src/model/characteristic_value.dart';
 import 'package:flutter_reactive_ble/src/model/qualified_characteristic.dart';
 import 'package:flutter_reactive_ble/src/model/result.dart';
+import 'package:flutter_reactive_ble/src/model/unit.dart';
 import 'package:flutter_reactive_ble/src/model/uuid.dart';
 import 'package:flutter_reactive_ble/src/model/write_characteristic_info.dart';
 import 'package:flutter_reactive_ble/src/plugin_controller.dart';
@@ -154,8 +155,8 @@ void main() {
           setUp(() {
             info = WriteCharacteristicInfo(
               characteristic: characteristic,
-              result: const Result<void,
-                  GenericFailure<WriteCharacteristicFailure>>.success(1),
+              result: const Result<Unit,
+                  GenericFailure<WriteCharacteristicFailure>>.success(Unit()),
             );
 
             when(_controller.writeCharacteristicWithResponse(any, any))
@@ -172,7 +173,7 @@ void main() {
             setUp(() {
               info = WriteCharacteristicInfo(
                 characteristic: characteristic,
-                result: const Result<void,
+                result: const Result<Unit,
                     GenericFailure<WriteCharacteristicFailure>>.failure(
                   GenericFailure<WriteCharacteristicFailure>(
                     code: WriteCharacteristicFailure.unknown,
@@ -200,8 +201,8 @@ void main() {
             setUp(() {
               info = WriteCharacteristicInfo(
                 characteristic: characteristic,
-                result: const Result<void,
-                    GenericFailure<WriteCharacteristicFailure>>.success(1),
+                result: const Result<Unit,
+                    GenericFailure<WriteCharacteristicFailure>>.success(Unit()),
               );
 
               when(_controller.writeCharacteristicWithoutResponse(any, any))
@@ -220,7 +221,7 @@ void main() {
             setUp(() {
               info = WriteCharacteristicInfo(
                 characteristic: characteristic,
-                result: const Result<void,
+                result: const Result<Unit,
                     GenericFailure<WriteCharacteristicFailure>>.failure(
                   GenericFailure<WriteCharacteristicFailure>(
                     code: WriteCharacteristicFailure.unknown,

test/converter/protobuf_converter_test.dart

@@ -400,7 +400,7 @@ void main() {
             .iif(
                 success: (_) => throw AssertionError("Not expected to succeed"),
                 failure: (f) => f!);
-        expect(result?.code, WriteCharacteristicFailure.unknown);
+        expect(result.code, WriteCharacteristicFailure.unknown);
       });
     });
 
@@ -433,7 +433,7 @@ void main() {
             .iif(
                 success: (_) => throw AssertionError("Not expected to succeed"),
                 failure: (f) => f!);
-        expect(result?.code, ConnectionPriorityFailure.unknown);
+        expect(result.code, ConnectionPriorityFailure.unknown);
       });
     });
 

test/plugin_controller_test.dart

@@ -265,7 +265,7 @@ void main() {
             // ignore: void_checks
             characteristic: characteristic,
             // ignore: void_checks
-            result: const Result.success(0));
+            result: const Result.success(Unit()));
 
         when(_methodChannel.invokeMethod<List<int>?>(any, any)).thenAnswer(
           (_) async => [1],