Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a maintainer #21

Open
rreusser opened this issue Mar 30, 2016 · 5 comments
Open

Add a maintainer #21

rreusser opened this issue Mar 30, 2016 · 5 comments

Comments

@rreusser
Copy link

Thanks for this plugin! It looks like there are a few issues and PRs that could use attention though. Is it possible to add a maintainer in order to get the PRs sorted out? Or perhaps to think about merging this + PRs into one of the other fs modules? I'd be glad to volunteer.

Ref: #9 #15 #20 and timsuchanek#1

@faceyspacey
Copy link

faceyspacey commented May 14, 2016

we may be better off merging this android code into one of these:

https://github.com/aroth/react-native-uploader
https://github.com/wootwoot1234/react-native-transfer
https://github.com/booxood/react-native-file-upload

This is the only one with Android support that I've found. And the other ones seem more actively maintained. This one seems to have missing features on iOS, such as the params option.

From my standpoint, I have everything I currently need for iOS, but in the near future will need Android support + progress reporting for android.. @aroth's package seems like the most stable and maintained, but perhaps is missing a few newer things other forks have. It also has the best presentation in the readme, I think the most stars, etc. I could be wrong, but that seems to be the one all these related packages should coalesce around. That's the one I recently decided to use. ...@wootwoot1234's repo also seems to be gaining steam though.

@aroth
Copy link

aroth commented May 14, 2016

I'd be interested in helping make this happen as part of my react-native-uploader lib.

https://github.com/aroth/react-native-uploader

@faceyspacey
Copy link

there's a lot of dangling forks and pull requests, but it seems you could clean house by bringing it all together under one roof.

@wootwoot1234
Copy link

I'm happy to combine my project too. I thought React Native started supporting uploading, is that only with iOS?

@rreusser
Copy link
Author

FWIW, I just started a new job that moves away from RN a bit. I'm forever appreciative of and indebted to y'all for putting this stuff together, but might struggle to pull off high-level actual-problem-solving thought on this at the moment. Glad to help if it's tedious straightforward stuff thought 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants