Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rating display issues in picture.tpl #26

Open
tkuther opened this issue Apr 18, 2016 · 3 comments
Open

Rating display issues in picture.tpl #26

tkuther opened this issue Apr 18, 2016 · 3 comments
Labels

Comments

@tkuther
Copy link
Contributor

tkuther commented Apr 18, 2016

Hi,

I'm using latest Piwigo 2.8.0 and absolutely love your bootstrap theme. I noticed some issues with the display of ratings below the image on picture.tpl, though.

a) the setting from Administration -> Configuration -> Options -> Display -> "Rating" is ignored. Rating is displayed even when it's disabled there.
b) Guests can see the text "Rate this image" (no stars though), even "guests can rate" is disabled in Configuration -> Options -> Common -> Permissions. They shouldn't see the text at all.
c) Guests can not see the stars after "Average rating" even the picture has been rated (if there is no rating, this is to be expected) when "guests can rate" is disabled. They should be able to see both the text and the stars (unless it's disabled, see a))

I'm trying to come up with a pull request. a) should be easy, the other two require some deeper dive into Piwigo's template variable stuff.

@tkuther
Copy link
Contributor Author

tkuther commented Apr 18, 2016

.. I was unable to fix c), that needs patching include/picture_rate.inc.php in Piwigo itself.

@Philio Philio added the bug label Aug 23, 2016
@Philio
Copy link
Owner

Philio commented Aug 23, 2016

Sorry for the long time to respond and thanks for the PR, I'll look at getting this merged.

@Philio
Copy link
Owner

Philio commented Aug 23, 2016

I've merged the PR, will see if I can find a workaround for c at some point in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants