Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend Exception Handling #11

Open
PhantomLel opened this issue Nov 20, 2022 · 3 comments
Open

Backend Exception Handling #11

PhantomLel opened this issue Nov 20, 2022 · 3 comments
Labels
enhancement New feature or request moderate priority schema Description of a standard format

Comments

@PhantomLel
Copy link
Owner

In the case that a request fails because of perhaps invalid request params or room does not exist or whatever, we should have an event sent to the client detailing the exception.

event 'event_error'
{
   msg : "some message to tell what went wrong"
}

This is important because it is quite annoying to debug by using print statements! If something goes wrong, we need to tell the client that something has went wrong so that a message can be displayed or something. Whenever a non-custom exception is encountered, it probably should just send back a default message, but if a custom exception is triggered, we should send back some custom message probably.

@PhantomLel PhantomLel added enhancement New feature or request schema Description of a standard format moderate priority labels Nov 20, 2022
@clayrock78
Copy link
Collaborator

@PhantomLel

Do we want to close this issue? Is this still a problem for you or did we end up solving it?

@PhantomLel
Copy link
Owner Author

I think we still need to work on getting exceptions for all the different possible cases.

@clayrock78
Copy link
Collaborator

Okay, I am not sure how you want these exceptions to work. If you have anything specific in mind, could you lay it out? If not, we can discuss it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request moderate priority schema Description of a standard format
Projects
None yet
Development

No branches or pull requests

2 participants