Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent API between make...With and verify...With + misleading documentation #18

Open
hce opened this issue Mar 26, 2018 · 0 comments

Comments

@hce
Copy link

hce commented Mar 26, 2018

verifyPasswordWith has an additional parameter of type (Int -> Int) with the description "A function to modify the strength"

makePasswordWith doesn't have this parameter. IMHO it's more consistent to either offer this parameter for both functions or not at all.

Also, the documentation is a bit misleading: "modify the strength" made me assume I just have to use the identity function if I didn't want to modify the strength (and why whould I want to?, I thought) Little did I realize that I needed to supply (2^) if I wanted to be able to successfully verify passwords hashed with makePasswordWith...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant