Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate the code #17

Open
chreekat opened this issue Jun 1, 2016 · 0 comments
Open

Deduplicate the code #17

chreekat opened this issue Jun 1, 2016 · 0 comments

Comments

@chreekat
Copy link

chreekat commented Jun 1, 2016

It would be nice to share as much code as possible between the two libraries.

I've got a branch that takes one approach to this. It builds off my pending PR, so I don't want to open a second PR for it (too much noise in the diff). You can see the changes here, though:

https://github.com/chreekat/pwstore/compare/sync-versions...chreekat:deduplicate-generic-code?expand=1

The strategy used here is to make pwstore-fast depend on pwstore-purehaskell. It just hides the high-level API, re-implements it in terms of its own pbkfd1/2, and re-exports the rest.

The thing is, I'm not sure this is a great solution, since there's still duplication in the export list and in the Haddocks for the high-level API. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant