Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to configure user and group id #47

Open
miracle091 opened this issue Jan 17, 2023 · 5 comments
Open

ability to configure user and group id #47

miracle091 opened this issue Jan 17, 2023 · 5 comments

Comments

@miracle091
Copy link

technically possible and here is the link of the official documentations
i can push a pr for this change, but first what is the best ID for user and group for use by default?

@PeterDaveHello
Copy link
Owner

Is this trying to solve the container and host user/group id mapping issue?

@miracle091
Copy link
Author

that and avoid possible (future?) problems with privileges escalation

@PeterDaveHello
Copy link
Owner

@miracle091 Okay ... I don't very mind that personally, and not sure if privileges escalation issues really exists with it, because that can be a massive issue already?

Anyway, a pull request is still welcome, please just make sure it's not too complex to be understood and used, I'll see how can I merge it. Thanks for the contribution!

@miracle091
Copy link
Author

miracle091 commented Jan 17, 2023

about an actual issue i don't know, but for my experience is better have it already ready to use that wait for a fix or a workaround.

the implementation is something that have a default value (like 1000 or others number) and the possibility to modify it using the -e flag if someone need/want it, for most users is just a drop-in and nothing to worry about

@miracle091
Copy link
Author

#48 have done a pr for some minimal changes, during my tests have found that the alpine use a custom user and change it is a real pain. the solutution can be two, for what have seen:

  1. change build image with something else, like debian/ubuntu and derivates
  2. discard my idea and leave everything as it is now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants