Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supplement parcellated time series and connectivity CIFTI files with TSVs #555

Closed
tsalo opened this issue Oct 3, 2022 · 3 comments · Fixed by #785
Closed

Supplement parcellated time series and connectivity CIFTI files with TSVs #555

tsalo opened this issue Oct 3, 2022 · 3 comments · Fixed by #785
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request

Comments

@tsalo
Copy link
Member

tsalo commented Oct 3, 2022

Summary

The atlas time series and connectivity matrices are currently stored as CIFTI files. We should change them to TSV files.

Additional details

This stems from @kahinimehta's comment in #517 (comment).
I've split it off into a separate issue because this is a file format change, rather than just a naming change.
@tsalo tsalo added enhancement New feature or request breaking-change PRs that change results or interfaces. labels Oct 3, 2022
@tsalo
Copy link
Member Author

tsalo commented Oct 4, 2022

@kahinimehta you said that this should be pretty easy. Do you know the Connectome WB commands to do it?

@tsalo tsalo mentioned this issue Oct 4, 2022
Closed
2 tasks
@tsalo
Copy link
Member Author

tsalo commented Oct 4, 2022

I've actually been struggling to get the CIFTI tests run on my laptop- the -cifti-correlation step just gives me an "Illegal instruction" no matter what I try. This has really incentivized me to find a workaround for this step, which led me to opening #559. Basically, I want to just use nibabel and pandas to get the time series and correlations earlier on.

@tsalo tsalo mentioned this issue Feb 2, 2023
Merged
@tsalo
Copy link
Member Author

tsalo commented Feb 10, 2023 •
edited
Loading

The DCAN team wanted us to supplement, rather than replace.

@tsalo tsalo changed the title Replace parcellated time series and connectivity CIFTI files with TSVs Supplement parcellated time series and connectivity CIFTI files with TSVs Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change PRs that change results or interfaces. enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@tsalo