Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Use HMAC-SHA512 #123

Open
saeveritt opened this issue Jul 7, 2018 · 2 comments
Open

Use HMAC-SHA512 #123

saeveritt opened this issue Jul 7, 2018 · 2 comments
Milestone

Comments

@saeveritt
Copy link
Member

saeveritt commented Jul 7, 2018

For Kutil when generating from string seed.
https://gist.github.com/sipa/1799467#file-gistfile1-txt-L97-L104
https://tools.ietf.org/rfc/rfc4231.txt

Right now Kutil uses a single sha256 hash.
https://github.com/PeerAssets/pypeerassets/blob/master/pypeerassets/kutil.py#L34-L35

Resources:
https://en.wikipedia.org/wiki/PBKDF2

@saeveritt
Copy link
Member Author

The proposal states to use the string "Bitcoin seed" when calculating I ( the value containing the master secret key and master chain code, where the 256 bits on the left of the 512 hash is the private key and the 256 bits on the right is the chain code.).
I = HMAC-SHA512(key="Bitcoin seed", msg=S)

Perhaps we can standardize all PeerAssets HD wallets to use the seed "PeerAssets seed" regardless of what network is being used.

@peerchemist
Copy link
Member

Perhaps we can standardize all PeerAssets HD wallets to use the seed "PeerAssets seed" regardless of what network is being used.

That sounds like a good idea.

@peerchemist peerchemist added this to the 0.6 milestone Aug 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants