fix(pat modal): Trigger pat-modal-ready event only once.

thet · thet · commit ddb7c5d5adbe · 2022-07-15T16:46:35.000+02:00
For pat-modal instances on anchor elements where pat-inject is involved the
event ``pat-modal-ready`` was triggered twice. This is now fixed and the event
is only triggered after the modal was inserted.
diff --git a/src/pat/modal/modal.js b/src/pat/modal/modal.js
@@ -63,13 +63,6 @@ export default Base.extend({
             $("#pat-modal").detach();
         });
 
-        this.el.addEventListener("pat-inject-success", () => {
-            // Dispatch the pat-modal-ready event after injection is done.
-            this.el.dispatchEvent(
-                new Event("pat-modal-ready", { bubbles: true, cancelable: true })
-            );
-        });
-
         inject.init(this.$el, opts);
     },
 
diff --git a/src/pat/modal/modal.test.js b/src/pat/modal/modal.test.js
@@ -147,7 +147,7 @@ describe("pat-modal", function () {
             await utils.timeout(1); // wait a tick for async to settle.
 
             // Opened immediately
-            expect(callback).toHaveBeenCalled();
+            expect(callback).toHaveBeenCalledTimes(1);
         });
 
         it("1.7 - Dispatch pat-modal-ready with a inject-modal.", async function () {
@@ -159,17 +159,17 @@ describe("pat-modal", function () {
             `;
 
             const callback = jest.fn();
+            document.body.addEventListener("pat-modal-ready", callback);
             const modal_el = document.querySelector(".pat-modal");
-            modal_el.addEventListener("pat-modal-ready", callback);
             pattern.init(modal_el);
             await utils.timeout(1); // wait a tick for async to settle.
 
             expect(callback).not.toHaveBeenCalled();
 
-            answer("<html><body><div></div></body></html>");
+            answer(`<html><body><div></div></body></html>`);
             modal_el.click();
             await utils.timeout(1); // wait a tick for async to settle.
-            expect(callback).toHaveBeenCalled();
+            expect(callback).toHaveBeenCalledTimes(1);
         });
 
         it("1.8 - Submit form, do injection and close overlay.", async function () {
