fix(pat inject): Fix code error with not scanning and triggering for comment nodes.

thet · thet · commit c281ae45d8d4 · 2022-08-19T17:31:08.000+02:00
diff --git a/src/pat/inject/inject.js b/src/pat/inject/inject.js
@@ -1105,7 +1105,7 @@ $(document).on("patterns-injected.inject", async (ev, cfg, trigger, injected) =>
         // Remove the executing class, add the executed class to the element with pat.inject on it.
         $(trigger).removeClass(cfg.executingClass).addClass(cfg.executedClass);
     }
-    if (injected.nodeType !== TEXT_NODE && injected !== COMMENT_NODE) {
+    if (injected.nodeType !== TEXT_NODE && injected.nodeType !== COMMENT_NODE) {
         registry.scan(injected, null, { type: "injection", element: trigger });
         $(injected).trigger("patterns-injected-scanned");
 
diff --git a/src/pat/inject/inject.test.js b/src/pat/inject/inject.test.js
@@ -602,6 +602,54 @@ describe("pat-inject", function () {
 
             spy_ajax.mockRestore();
         });
+
+        it("does not trigger the patterns-injected-scanned event for text nodes", async function () {
+            const spy_ajax = jest.spyOn($, "ajax").mockImplementation(() => deferred);
+            var $a = $('<a class="pat-inject" href="test.html#someid">link</a>');
+            var $div = $('<div id="someid" />');
+            $("#lab").empty().append($a).append($div);
+            var callback = jest.fn();
+            $(document).on("patterns-injected-scanned", callback);
+            pattern.init($a);
+            $a.trigger("click");
+            answer(`
+              <html>
+                <body>
+                  <div id="someid">
+                    repl
+                  </div>
+                </body>
+              </html>
+            `);
+            await utils.timeout(1); // wait a tick for async to settle.
+            expect(callback).not.toHaveBeenCalled();
+
+            spy_ajax.mockRestore();
+        });
+
+        it("does not trigger the patterns-injected-scanned event for comment nodes", async function () {
+            const spy_ajax = jest.spyOn($, "ajax").mockImplementation(() => deferred);
+            var $a = $('<a class="pat-inject" href="test.html#someid">link</a>');
+            var $div = $('<div id="someid" />');
+            $("#lab").empty().append($a).append($div);
+            var callback = jest.fn();
+            $(document).on("patterns-injected-scanned", callback);
+            pattern.init($a);
+            $a.trigger("click");
+            answer(`
+              <html>
+                <body>
+                  <div id="someid">
+                    <!-- repl -->
+                  </div>
+                </body>
+              </html>
+            `);
+            await utils.timeout(1); // wait a tick for async to settle.
+            expect(callback).not.toHaveBeenCalled();
+
+            spy_ajax.mockRestore();
+        });
     });
 
     describe("DOM tests", function () {

Original file line number	Diff line number	Diff line change
`@@ -1105,7 +1105,7 @@ $(document).on("patterns-injected.inject", async (ev, cfg, trigger, injected) =>`
`1105`	`1105`	`// Remove the executing class, add the executed class to the element with pat.inject on it.`
`1106`	`1106`	`$(trigger).removeClass(cfg.executingClass).addClass(cfg.executedClass);`
`1107`	`1107`	`}`
`1108`		`- if (injected.nodeType !== TEXT_NODE && injected !== COMMENT_NODE) {`
	`1108`	`+ if (injected.nodeType !== TEXT_NODE && injected.nodeType !== COMMENT_NODE) {`
`1109`	`1109`	`registry.scan(injected, null, { type: "injection", element: trigger });`
`1110`	`1110`	`$(injected).trigger("patterns-injected-scanned");`
`1111`	`1111`