Skip to content

Commit 985f4e2

Browse files
committed
feat(core parser): Also convert on/off values to boolean for boolean arguments.
1 parent 315735f commit 985f4e2

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

src/core/parser.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,8 @@ class ArgumentParser {
161161
value === "true" ||
162162
value === "y" ||
163163
value === "yes" ||
164-
value === "y";
164+
value === "y" ||
165+
value === "on";
165166
} else if (typeof value === "number") {
166167
value = !!value;
167168
} else {

src/core/parser.test.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -782,6 +782,18 @@ describe("The Patterns parser", function () {
782782
parser.addArgument("value", false);
783783
expect(parser._coerce("value", "unknown")).toBe(false);
784784
});
785+
786+
it("String with on", function () {
787+
var parser = new ArgumentParser();
788+
parser.addArgument("value", false);
789+
expect(parser._coerce("value", "on")).toBe(true);
790+
});
791+
792+
it("String with off", function () {
793+
var parser = new ArgumentParser();
794+
parser.addArgument("value", false);
795+
expect(parser._coerce("value", "off")).toBe(false);
796+
});
785797
});
786798

787799
describe("Convert to number", function () {

0 commit comments

Comments
 (0)