pat-inject: next-href wasn't working as advertised.

Add the ability to use a URL for next-href and let that be properly set.

Author: jcbrand

changes.md

@@ -9,6 +9,7 @@
 - Add the class `modal-active` to the `body` element whenever a modal is in the DOM.
 - New pattern: `pat-tabs`. See the relevant documentation.
 - Bugfix: `pat-validation` still validates removed clones from `pat-clone`.
+- Let the next-href option of pat-inject work as advertised.
 - #436 Remove `pat-bumper` restriction that scroll container must be the direct parent.
 
 ## 2.0.12 - Oct. 9, 2015

jshintrc-tests

@@ -11,6 +11,7 @@
     "white": false,
     "quotmark": false,
     "predef": [
+        "Event",
         "Markdown",
         "Modernizr",
         "define",

src/pat/inject/inject.js

@@ -43,15 +43,19 @@ define([
             }
             $el.data("pat-inject", cfgs);
 
-            // In case next-href is specified the anchor's href will
-            // be set to it after the injection is triggered. In case
-            // the next href already exists, we do not activate the
-            // injection but instead just change the anchors href.
-            var $nexthref = $(cfgs[0].nextHref);
-            if ($el.is("a") && $nexthref.length > 0) {
-                log.debug("Skipping as next href already exists", $nexthref);
-                // XXX: reconsider how the injection enters exhausted state
-                return $el.attr({href: (window.location.href.split("#")[0] || "") + cfgs[0].nextHref});
+            if (cfgs[0].nextHref && cfgs[0].nextHref.indexOf('#') === 0) {
+                // In case the next href is an anchor, and it already
+                // exists in the page, we do not activate the injection
+                // but instead just change the anchors href.
+
+                // XXX: This is used in only one project for linked
+                // fullcalendars, it's sanity is wonky and we should
+                // probably solve it differently.
+                if ($el.is("a") && $(cfgs[0].nextHref).length > 0) {
+                    log.debug("Skipping as next href is anchor, which already exists", cfgs[0].nextHref);
+                    // XXX: reconsider how the injection enters exhausted state
+                    return $el.attr({href: (window.location.href.split("#")[0] || "") + cfgs[0].nextHref});
+                }
             }
 
             switch (cfgs[0].trigger) {
@@ -118,7 +122,7 @@ define([
                 cfgs = $sub.data("pat-inject");
 
             // store the params of the subform in the config, to be used by history
-            $(cfgs).each(function(i, v) {v.params = $.param($sub.serializeArray())});
+            $(cfgs).each(function(i, v) {v.params = $.param($sub.serializeArray());});
 
             try {
                 $el.trigger("patterns-inject-triggered");
@@ -407,9 +411,10 @@ define([
                     inject._performInjection.apply(this, [$el, sources$[idx], cfg, ev.target]);
                 });
             });
-            if (cfgs[0].nextHref) {
-                $el.attr({href: (window.location.href.split("#")[0] || "") +
-                            cfgs[0].nextHref});
+            if (cfgs[0].nextHref && $el.is("a")) {
+                // In case next-href is specified the anchor's href will
+                // be set to it after the injection is triggered.
+                $el.attr({href: cfgs[0].nextHref});
                 inject.destroy($el);
             }
             $el.off("pat-ajax-success.pat-inject");

src/pat/inject/tests.js

@@ -15,6 +15,28 @@ define(["pat-inject", "pat-utils"], function(pattern, utils) {
             $("#lab").remove();
         });
 
+        describe("The next-href argument", function() {
+            afterEach(function() {
+                $("#lab").empty();
+            });
+
+            it("allows you to specify the href to be applied to the clicked element after injection", function () {
+                var $a = $("<a class=\"pat-inject\" data-pat-inject=\"next-href: http://patternslib.com\" href=\"/src/pat/inject/inject-sources.html#pos-1\">link</a>");
+                var $div = $("<div id=\"pos-1\" />");
+                $("#lab").append($a).append($div);
+                var dummy_event = {
+                    'jqxhr': {'responseText': 'foo'},
+                    'isPropagationStopped': function () { return true; }
+                };
+                var cfgs = pattern.extractConfig($a, {});
+                pattern.verifyConfig(cfgs, $a);
+                pattern._onInjectSuccess($a, cfgs, dummy_event);
+                expect(cfgs[0].nextHref).toBe('http://patternslib.com');
+                expect($a.attr("href")).toBe('http://patternslib.com');
+            });
+
+        });
+
         describe("The loading-class argument", function() {
 
             afterEach(function() {