Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substring throws Exception #2

Closed
robxu9 opened this issue Mar 21, 2012 · 5 comments
Closed

Substring throws Exception #2

robxu9 opened this issue Mar 21, 2012 · 5 comments

Comments

@robxu9
Copy link

robxu9 commented Mar 21, 2012

In Database, the getStatement function can throw an exception if the trimmed query is not of the length expected.
You need to check the size before substringing.

@PatPeter
Copy link
Owner

I read this issue when you first submitted it and I believe I fixed it in a commit that has not been pushed. I'll check when I have the free time to code.

@robxu9
Copy link
Author

robxu9 commented Apr 30, 2012

I fixed it in https://github.com/Minequest/Minequest-Reloaded-Core and also added an H2 version of the library. You can check there if you want.

@PatPeter
Copy link
Owner

... how did I not reply to this? I have a clear recollection of replying to you.

Anyway, could you do me a huge favor and pull request your changes?

https://github.com/PatPeter/SQLibrary/pulls

I'm about to make many edits to the library and do not want them to conflict with your changes (last I worked on this was March).

@robxu9
Copy link
Author

robxu9 commented Jul 30, 2012

Hm, push your changes first. I can always adapt them easily.

@PatPeter
Copy link
Owner

PatPeter commented Sep 9, 2012

It only took me 6 months, but I finally fixed this issue (finally).

Feel free to push your changes at anytime. I would love that H2 driver.

@PatPeter PatPeter closed this as completed Sep 9, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants