Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New commits give worse performance #19

Closed
Parskatt opened this issue Jan 30, 2024 · 2 comments · Fixed by #20
Closed

New commits give worse performance #19

Parskatt opened this issue Jan 30, 2024 · 2 comments · Fixed by #20

Comments

@Parskatt
Copy link
Owner

Somewhere between 7f8b2e4 and main something was introduced that reduces performance on megadepth1500 by ~1%. Need to find the culprit.
@Parskatt Parskatt mentioned this issue Jan 30, 2024
Merged
@sgk-000
Copy link

sgk-000 commented Feb 6, 2024

This issue has already fixed?

@Parskatt
Copy link
Owner Author

Parskatt commented Feb 6, 2024

Yep, it was caused by default argument for the match sampling to be different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dev Parskatt/RoMa
2 participants
@Parskatt @sgk-000