Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart Linking: Review modal alters styling in PCH Sidebar #2627

Closed
acicovic opened this issue Jul 10, 2024 · 0 comments · Fixed by #2652
Closed

Smart Linking: Review modal alters styling in PCH Sidebar #2627

acicovic opened this issue Jul 10, 2024 · 0 comments · Fixed by #2652
Labels
Feature: Content Helper Type: Bug
Milestone
3.16.1

Comments

@acicovic
Copy link
Collaborator

acicovic commented Jul 10, 2024 •
edited

Describe the bug

When the Review Smart Links modal is invoked, it alters some styles in the PCH Sidebar.

Initial styling:

image

When the modal is shown:

  • Notice how some of the text styling changes in the sidebar.
  • The modal's title font changes, and seems to leak in the sidebar.
image

This styling glitch doesn't appear when the close dialog appears:
image

To Reproduce

  • In the PCH Sidebar, click the Add Smart Links button.
  • Observe the styling changes in the Sidebar.

Expected behavior

The modal's title font should probably not change, and it should have no impact on the PCH Sidebar's styling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature: Content Helper Type: Bug
Projects
None yet
Milestone
3.16.1
Development

Successfully merging a pull request may close this issue.

PCH Smart Linking: Fix CSS leaking from the Block Preview Parsely/wp-parsely
2 participants
@vaurdan @acicovic