Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider polyfill solution to allow wp-scripts upgrades #2624

Open
acicovic opened this issue Jul 10, 2024 · 1 comment
Open

Consider polyfill solution to allow wp-scripts upgrades #2624

acicovic opened this issue Jul 10, 2024 · 1 comment

Comments

@acicovic
Copy link
Collaborator

Is your feature request related to a problem?

When we attempted to upgrade to wp-scripts v28, our tooling based on React disappeared. This was experienced by others as well, and the main issue is here.

Apparently, there are 2 propositions:

  1. Don't upgrade to wp-scripts v28 until the minimum WP version for the plugin is 6.6. This is what's officially proposed in the changelog and related article.
  2. There's a mention of using a polyfill solution.

Describe the solution you'd like

For now, we've paused dependabot updates for v28.

Although this is what's officially proposed, the first proposition's viability isn't a given in my opinion. If a polyfill solution is implementable, we should look into this possibility. It seems that the polyfill solution will require updating our minimum WP version to at least 5.9, which shouldn't be an issue.

@acicovic
Copy link
Collaborator Author

Let's remember to remove "@typescript-eslint/method-signature-style": "error" from .eslintrc when we're done with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant