Move field deletion logic into mongo adapter #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // the collectionPrefix. Also, Schemas.js, the caller of this function, only stores the collection | ||
| // itself, and not the prefix. Eventually Parse Server won't care what a SchemaCollection is and | ||
| // will just tell the DB adapter to do things and it will do them. | ||
| deleteFields(className: string, fieldNames, pointerFieldNames, collectionPrefix, adaptiveCollection) { |
There was a problem hiding this comment.
could we implement it on MongoCollection.js instead? otherwise that's good
There was a problem hiding this comment.
No, the MongoCollection doesn't have access to the schema collection.
Current coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently due to the _collectionPrefix not being stored in the database adapter, we need to do all sorts of crazy stuff to make sure the mongo adapter knows where the data it needs to delete is. Will fix in a later PR.