Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly let masterKey add fields #1291

Merged
merged 1 commit into from
Mar 31, 2016
Merged

Properly let masterKey add fields #1291

merged 1 commit into from
Mar 31, 2016

Conversation

flovilmart
Copy link
Contributor

fixes #1257

@codecov-io
Copy link

Current coverage is 93.02%

Merging #1291 into master will not affect coverage as of 029003d

@@            master   #1291   diff @@
======================================
  Files           84      84       
  Stmts         5275    5279     +4
  Branches       960     961     +1
  Methods          0       0       
======================================
+ Hit           4907    4911     +4
  Partial         11      11       
  Missed         357     357

Review entire Coverage Diff as of 029003d

Powered by Codecov. Updated on successful CI builds.

@flovilmart flovilmart mentioned this pull request Mar 31, 2016
Closed
@drew-gross drew-gross merged commit 781e81d into master Mar 31, 2016
@drew-gross drew-gross deleted the flovilmart.issue1257 branch March 31, 2016 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

canAddField does not respect master key
3 participants
@flovilmart @codecov-io @drew-gross