Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly a bugged or incorrectly configured modpack forcing a publish each commit #74

Closed
ghost opened this issue Feb 18, 2024 · 8 comments · Fixed by #81
Closed

Possibly a bugged or incorrectly configured modpack forcing a publish each commit #74

ghost opened this issue Feb 18, 2024 · 8 comments · Fixed by #81
Assignees

Comments

@ghost
Copy link

ghost commented Feb 18, 2024

Describe the bug
Each time a commit is made onto main, the commit itself will cause a publish to occur rather than updating a pull request.

Expected behavior
It should make a pull request and not publish.

Logs
https://pastebin.com/zWuHUX5i

@sofiedotcafe
Copy link
Contributor

This is intresting, could you share the GitHub repo by any change so I could see closer?

@sofiedotcafe sofiedotcafe self-assigned this Feb 28, 2024
@ghost
Copy link
Author

ghost commented Mar 17, 2024

@sofiedotcafe
Copy link
Contributor

sofiedotcafe commented Mar 17, 2024

https://github.com/DannyLeWasTaken/DAM

Could be caused by the "bit excessive" use of the bump action, release please should handle bumps by itself.

The action is mainly used for bumping from the 0.1.0 to 1.0.0, like beta to release.

You could try to generate an new project from the template if you want, since this seems like an release please thing, at least I haven't seen this before.

@ghost
Copy link
Author

ghost commented Mar 25, 2024

Gotcha. A fix would be nice since it would be annoying to have to do this if my modpack bugs out

@ghost ghost closed this as completed Mar 25, 2024
@ghost ghost reopened this Mar 25, 2024
@Aninuscsalas
Copy link

Same issue here:

Instead of bumping the pack and creating a PR the action releases itself as the previous version again and again.

@sofiedotcafe
Copy link
Contributor

@sofiedotcafe
Copy link
Contributor

Hey! I found the issue:

If you were previously configuring advanced options via GitHub action inputs, you will need to configure via the release-please manifest configuration instead. Below, you can see a mapping of the old option to the new option:

It seems that the update from release-please-action v3 to v4 broke this, weird that the dependency bot didn't find this as an issue!

@sofiedotcafe sofiedotcafe linked a pull request Apr 1, 2024 that will close this issue
@sofiedotcafe
Copy link
Contributor

This seems to be mainly the fault of GitHub actions, that's why the issue #78 was created...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants