Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client and server packs #57

Open
Conquerix opened this issue Sep 29, 2023 · 11 comments
Open

Client and server packs #57

Conquerix opened this issue Sep 29, 2023 · 11 comments
Assignees
Labels
good first issue Good for newcomers question Further information is requested

Comments

@Conquerix
Copy link
Contributor

Is it possible to have both client and server versions of one pack at the same time and released together for a new version ?

@Conquerix Conquerix added the question Further information is requested label Sep 29, 2023
@sofiedotcafe
Copy link
Contributor

@Conquerix I haven't looked into it, but you could look into it if mc-publish supports it

Does this require different like upload locations? Like different pages etc. on Modrinth?

@Conquerix
Copy link
Contributor Author

Actually I upload my pack to curse forge only (mainly because of the mod ms present). On there when uploading a client pack version, you can include other files, and people usually put the server versions there.
I'll look a bit more into mc-publish

@sofiedotcafe
Copy link
Contributor

I'll look a bit more into mc-publish

Thanks!
At least different upload locations on modrinth/curseforge is planned! :3

@sofiedotcafe sofiedotcafe added this to the Release milestone Sep 30, 2023
@Conquerix
Copy link
Contributor Author

Ok so I looked into it a bit more, it seems that one can use files-primary and files-secondary to specify which files go where when uploading several of them
In this discussion it seems to be the case, although I don't really know what globs are, I get the idea.
With this it seems there need to be a way to distinguish easily between the server and client packs.

Maybe it would be worth looking at a setup with one repo for one modpack project, with one directory for the client and one for the server, instead of having one project per folder in the same repo.

@Conquerix
Copy link
Contributor Author

Ok nevermind with the primary and secondary files they seem to be deprecated (see here)
I wonder what would happen if the files input had several files in it. Would it need a lot of work to change ?

@sofiedotcafe
Copy link
Contributor

Would it need a lot of work to change ?

Hmm, idk if there is something like
type: client type of stuff?
But yea, currently its handling the uploads on its own (via GitHub Actions matrices) so it would be bit of an pain to change

@sofiedotcafe sofiedotcafe added the good first issue Good for newcomers label Sep 30, 2023
@Conquerix
Copy link
Contributor Author

The type: client thing seems to be in preparation for their v4 yup.
I'll try and see in my project how to do it without the matrices, seems doable and I have some free time :D

@Conquerix
Copy link
Contributor Author

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works.
If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

@sofiedotcafe
Copy link
Contributor

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works. If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

The problem with this, does it work with other "monorepo" style of uploads?
Like could It build like 3 different types of the pack e.g. quilt, fabric and forge like currently :3 ?

@Conquerix
Copy link
Contributor Author

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works. If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

The problem with this, does it work with other "monorepo" style of uploads?
Like could It build like 3 different types of the pack e.g. quilt, fabric and forge like currently :3 ?

What we could do is having a hybrid solution, for example, have each subdirectory of the git repo represent one pack, and in those there could be either the packwiz repo or 2 subdirectories client and server, each containing the corresponding packwiz repo of the same pack.
Btw,I've never seen a case where one pack has versions for different loaders without the versions being different projects, like Better MC

@sofiedotcafe
Copy link
Contributor

Ok so I completely modified the pipeline on my repo to try without the matrices, basically it works. If you put several files in the files field of mc-publish, it will publish the first one as the main file and the others as secondary files. It is fully working in my project.

The problem with this, does it work with other "monorepo" style of uploads?
Like could It build like 3 different types of the pack e.g. quilt, fabric and forge like currently :3 ?

What we could do is having a hybrid solution, for example, have each subdirectory of the git repo represent one pack, and in those there could be either the packwiz repo or 2 subdirectories client and server, each containing the corresponding packwiz repo of the same pack.
Btw,I've never seen a case where one pack has versions for different loaders without the versions being different projects, like Better MC

Currently, they are the same version because of #49

@sofiedotcafe sofiedotcafe removed this from the Release milestone Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants