Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player vs OfflinePlayer getBedSpawnLocation #7860

Open
Machine-Maker opened this issue May 30, 2022 · 3 comments · May be fixed by #11960
Open

Player vs OfflinePlayer getBedSpawnLocation #7860

Machine-Maker opened this issue May 30, 2022 · 3 comments · May be fixed by #11960
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. version: 1.19 Game version 1.19

Comments

@Machine-Maker
Copy link
Member

Expected behavior

When calling getBedSpawnLocation on an instance of CraftPlayer or CraftOfflinePlayer the result should be the same (or the discrepancy should be documented and predictable)

Observed/Actual behavior

They are different as shown here

test
[16:05:20 INFO]: [Paper-Test-Plugin] [STDOUT] online: true
[16:05:20 INFO]: [Paper-Test-Plugin] [STDOUT] spawn: Location{world=CraftWorld{name=world_nether},x=-7.5,y=89.0,z=-18.5,pitch=0.0,yaw=0.0}
[16:05:22 INFO]: Machine_Maker lost connection: Disconnected
[16:05:22 INFO]: Machine_Maker left the game
test
[16:05:27 INFO]: [Paper-Test-Plugin] [STDOUT] online: false
[16:05:27 INFO]: [Paper-Test-Plugin] [STDOUT] spawn: Location{world=CraftWorld{name=world_nether},x=-8.0,y=89.0,z=-18.0,pitch=0.0,yaw=0.0}

Steps/models to reproduce

  1. Set your spawn in the world
  2. Log the player's bed spawn loc
  3. log out
  4. get the instance of offlineplayer
  5. log the bed spawn loc

Plugin and Datapack List

none

Paper version

af3b377

Other

No response
@Machine-Maker Machine-Maker added type: bug Something doesn't work as it was intended to. status: needs triage labels May 30, 2022
@Machine-Maker Machine-Maker mentioned this issue May 30, 2022
Merged
@Machine-Maker Machine-Maker added status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. and removed status: needs triage labels Jun 2, 2022
@Doc94
Copy link
Contributor

Doc94 commented Jun 12, 2022

This is already fixed not?

@Machine-Maker
Copy link
Member Author

Afaik, no. The location is still different.

@Doc94
Copy link
Contributor

Doc94 commented Jun 12, 2022

Afaik, no. The location is still different.

Ahhh i see now.. the issue is more like by "findRespawnPositionAndUseSpawnBlock" where change the position a few... then not sure if is better try using this in OfflinePlayer or only add in docs for OfflinePlayer about the "exactly" position for bed?

@Lulu13022002 Lulu13022002 mentioned this issue Aug 5, 2022
Closed
@lynxplay lynxplay added the version: 1.19 Game version 1.19 label Aug 6, 2022
@lynxplay lynxplay moved this to accepted in Issues: Bugs Aug 6, 2022
@Machine-Maker Machine-Maker linked a pull request Jan 12, 2025 that will close this issue
Fix inconsistencies between offline/online spawn position getter #11960
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. type: bug Something doesn't work as it was intended to. version: 1.19 Game version 1.19
Projects
Issues: Bugs
Status: ✅ Accepted
Milestone
No milestone
3 participants
@Doc94 @Machine-Maker @lynxplay