Experimental and jd

Author: lynxplay

paper-api/src/main/java/io/papermc/paper/event/packet/UncheckedSignChangeEvent.java

@@ -1,6 +1,7 @@
 package io.papermc.paper.event.packet;
 
 import io.papermc.paper.math.BlockPosition;
+import io.papermc.paper.math.Position;
 import net.kyori.adventure.text.Component;
 import org.bukkit.block.sign.Side;
 import org.bukkit.entity.Player;
@@ -13,13 +14,16 @@
 import java.util.List;
 
 /**
- * Called when a sign edit packet has been received, but the location at which the sign should be edited
+ * Called when a client attempts to modify a sign, but the location at which the sign should be edited
  * has not yet been checked for the existence of a real sign.
  * <p>
  * Cancelling this event will prevent further processing of the sign change, but needs further handling
- * by the plugin because the local world might be in an inconsistent state.
+ * by the plugin as the client's local world might be in an inconsistent state.
+ *
+ * @see Player#openVirtualSign(Position, Side)
  */
 @NullMarked
+@ApiStatus.Experimental
 public class UncheckedSignChangeEvent extends PlayerEvent implements Cancellable {
 
     private static final HandlerList HANDLER_LIST = new HandlerList();

paper-api/src/main/java/org/bukkit/entity/Player.java

@@ -3481,13 +3481,14 @@ default void setNoTickViewDistance(int viewDistance) {
      * Open a sign for editing by the player.
      * <p>
      * The sign must only be placed locally for the player, which can be done with {@link #sendBlockChange(Location, BlockData)} and {@link #sendBlockUpdate(Location, TileState)}.
-     * A side-effect of this is that no events will be called for this action.
+     * A side-effect of this is that normal events, like {@link org.bukkit.event.block.SignChangeEvent} will not be called (unless there is an actual sign in the world).
      * </p>
      *
      * @param block The block where the client has a sign placed
      * @param side The side to edit
      * @see io.papermc.paper.event.packet.UncheckedSignChangeEvent
      */
+    @ApiStatus.Experimental
     void openVirtualSign(@NotNull Position block, @NotNull Side side);
 
     /**

paper-server/patches/sources/net/minecraft/server/network/ServerGamePacketListenerImpl.java.patch

@@ -2504,7 +2504,7 @@
 +            if (!new io.papermc.paper.event.packet.UncheckedSignChangeEvent(this.player.getBukkitEntity(),
 +                io.papermc.paper.util.MCUtil.toPosition(pos),
 +                packet.isFrontText() ? org.bukkit.block.sign.Side.FRONT : org.bukkit.block.sign.Side.BACK,
-+                filteredText.stream().map(line -> (net.kyori.adventure.text.Component) net.kyori.adventure.text.Component.text(line.raw())).toList())
++                filteredText.stream().<net.kyori.adventure.text.Component>map(line -> net.kyori.adventure.text.Component.text(line.raw())).toList())
 +                .callEvent()) {
 +                return;
 +            }