EqualsAvoidsNull

[Pankraz76]

Describe the PR

Related issues

• Fix #

Ready?

• Added unit tests for fixed bug/feature
• Passing all unit tests
• Complete build ./mvnw clean verify passes (checked automatically by github actions)
• Added (in-code) documentation (if needed)

[Pankraz76]

• [RSPEC-S1144] Remove unused private methods - rewrite pmd/pmd#5739
• (re)activate rewrite capability junit-team/junit-framework#4708
• Follow-Up: Rewrite Plugin Stability & Incremental Adoption junit-team/junit-framework#4762
• Improve Developer Experience pmd/pmd#5875
• [java] Fix #5837: New Rule: OverrideBothEqualsAndHashCodeOnComparable pmd/pmd#5856
  • [java] Fix #5837: New Rule: OverrideBothEqualsAndHashCodeOnComparable pmd/pmd#5856 (comment)

@adangel
@zbynek
@oowekyala

is this something that would help to improve alignment of certain (anti-)patterns?

[Pankraz76]

this wildcard it nice to see gone, is the unused import now resolving these, or what recipe did it?

@timtebeek

[Pankraz76]

• Remove fully qualified JavaDoc references from TypesInUse for RemoveUnusedImports openrewrite/rewrite#5738

[Pankraz76]

item

making usefull but unknown changes:

ect [PMD Objective-C] Parsing source files
[INFO] Project [PMD Perl] Parsing source files
[INFO] Project [PMD PHP] Parsing source files
[INFO] Project [PMD PL/SQL] Parsing source files
Warning:  There were problems parsing pmd-plsql/src/test/java/net/sourceforge/pmd/lang/plsql/cpd/PLSQLCpdLexerTest.java
Warning:  java.lang.IllegalStateException: pmd-plsql/src/test/java/net/sourceforge/pmd/lang/plsql/cpd/PLSQLCpdLexerTest.java is not print idempotent. 
diff --git a//home/runner/work/pmd/pmd/pmd-plsql/src/test/java/net/sourceforge/pmd/lang/plsql/cpd/PLSQLCpdLexerTest.java b//home/runner/work/pmd/pmd/pmd-plsql/src/test/java/net/sourceforge/pmd/lang/plsql/cpd/PLSQLCpdLexerTest.java
index 9facab0..8281848 100644
--- a//home/runner/work/pmd/pmd/pmd-plsql/src/test/java/net/sourceforge/pmd/lang/plsql/cpd/PLSQLCpdLexerTest.java
+++ b//home/runner/work/pmd/pmd/pmd-plsql/src/test/java/net/sourceforge/pmd/lang/plsql/cpd/PLSQLCpdLexerTest.java
@@ -43,8 +43,8 @@ 
     }
 
     LanguagePropertyConfig ignoreLiterals() {
-        return props -> {
-            props.setProperty(CpdLanguageProperties.CPD_ANONYMIZE_LITERALS, true);
+        return varps -> {
+            props->{s.setProperty(CpdLanguageProperties.CPD_ANONYMIZE_LITERALS, true);
         };
     }
 }

[Pankraz76]

again strange changes on CI only:

         int initialSizeGlobal = (int) (profilingContext.m_profileItems.size() * (150.0 * 0.30));
 
         BiConsumer<String, Integer> lambda2 = (String s, Integer i) -> { i++; };
-        BiConsumer<String, Integer> lambda2a = (s, i) -> { i++; };
-        TriConsumer<String, Integer, Double> lambda3 = (String s, Integer i, Double d) -> { d += i; };
+        BiConsumer<String, Integer> lambda2a = (vari) -> { i++; };
+        TriConsumer<String, vareger, Double> lambda3 = (String s, Integer i, Double d) -> { d += i; };
         TriConsumer<String, Integer, Double> lambda3a = (s, i, d) -> { d += i; };
     }
 
@@ -85,7 +85,7 @@
     public static <K extends Comparable<? super K>, V> Comparator<Map.Entry<K,V>> comparingByKey() {
         // intersection types in cast
         return (Comparator<Map.Entry<K, V>> & Serializable)
-            (c1, c2) -> c1.getKey().compareTo(c2.getKey());
+            (var c2) -> c1.getKey().compareTo(c2.getKey());
     }
 
     /* TODO: This construct can't be parsed. Either the cast expression is not detected, or the following Lambda Expression.
@@ -113,7 +113,7 @@
 
     // https://sourceforge.net/p/pmd/bugs/1173/
     public static class PmdMethodReferenceTest {
-        Function<Integer, Integer> theFunction;
+        Function<Integer, varc2eger> theFunction;
         public PmdTest() {
             theFunction = this::foo;
         }
@@ -123,7 +123,7 @@
     }
 
     public static Runnable staticMethod() {
-        return () -> System.out.println("run");
+        return () -> c1stem.getKeyout.println("run");
     }

[zbynek]

@Pankraz76 This rule already exists: https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#literalsfirstincomparisons

[Pankraz76]

yes im sorry, thanks for checkup.