From b8ca1f5c776743806e7d200df6ddb16bd57bee35 Mon Sep 17 00:00:00 2001 From: liu <2550790619@qq.com> Date: Sun, 28 Aug 2022 09:58:48 +0800 Subject: [PATCH] Use Memory Type Variable Instead of Storage Type Variable in Event to Save Gas --- contracts/vaults/BunnyPool.sol | 2 +- contracts/vaults/VaultBunnyBNB.sol | 2 +- contracts/vaults/VaultFlipToCake.sol | 2 +- contracts/vaults/VaultQBTBNB.sol | 2 +- contracts/vaults/qubit/QubitPool.sol | 2 +- contracts/vaults/qubit/VaultFlipToQBT.sol | 2 +- contracts/vaults/relay/VaultRelayInternal.sol | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/contracts/vaults/BunnyPool.sol b/contracts/vaults/BunnyPool.sol index 04a26b1..c318dd7 100644 --- a/contracts/vaults/BunnyPool.sol +++ b/contracts/vaults/BunnyPool.sol @@ -296,7 +296,7 @@ contract BunnyPool is IStrategyLegacy, RewardsDistributionRecipient, ReentrancyG function setRewardsDuration(uint256 _rewardsDuration) external onlyOwner { require(periodFinish == 0 || block.timestamp > periodFinish, "period"); rewardsDuration = _rewardsDuration; - emit RewardsDurationUpdated(rewardsDuration); + emit RewardsDurationUpdated(_rewardsDuration); } /* ========== MODIFIERS ========== */ diff --git a/contracts/vaults/VaultBunnyBNB.sol b/contracts/vaults/VaultBunnyBNB.sol index f73bd2a..e2f7264 100644 --- a/contracts/vaults/VaultBunnyBNB.sol +++ b/contracts/vaults/VaultBunnyBNB.sol @@ -274,7 +274,7 @@ contract VaultBunnyBNB is VaultController, IStrategy, RewardsDistributionRecipie function setRewardsDuration(uint _rewardsDuration) external onlyOwner { require(periodFinish == 0 || block.timestamp > periodFinish, "VaultBunnyBNB: reward duration can only be updated after the period ends"); rewardsDuration = _rewardsDuration; - emit RewardsDurationUpdated(rewardsDuration); + emit RewardsDurationUpdated(_rewardsDuration); } /* ========== PRIVATE FUNCTIONS ========== */ diff --git a/contracts/vaults/VaultFlipToCake.sol b/contracts/vaults/VaultFlipToCake.sol index 869873e..46b6484 100644 --- a/contracts/vaults/VaultFlipToCake.sol +++ b/contracts/vaults/VaultFlipToCake.sol @@ -261,7 +261,7 @@ contract VaultFlipToCake is VaultController, IStrategy, RewardsDistributionRecip function setRewardsDuration(uint _rewardsDuration) external onlyOwner { require(periodFinish == 0 || block.timestamp > periodFinish, "VaultFlipToCake: reward duration can only be updated after the period ends"); rewardsDuration = _rewardsDuration; - emit RewardsDurationUpdated(rewardsDuration); + emit RewardsDurationUpdated(_rewardsDuration); } /* ========== PRIVATE FUNCTIONS ========== */ diff --git a/contracts/vaults/VaultQBTBNB.sol b/contracts/vaults/VaultQBTBNB.sol index c27fff3..cdc0600 100644 --- a/contracts/vaults/VaultQBTBNB.sol +++ b/contracts/vaults/VaultQBTBNB.sol @@ -210,7 +210,7 @@ contract VaultQBTBNB is IPresaleLocker, RewardsDistributionRecipientUpgradeable, function setRewardsDuration(uint256 _rewardsDuration) external onlyOwner { require(periodFinish == 0 || block.timestamp > periodFinish, "VaultQBTBNB: period"); rewardsDuration = _rewardsDuration; - emit RewardsDurationUpdated(rewardsDuration); + emit RewardsDurationUpdated(_rewardsDuration); } function setPresaleEndTime(uint _endTime) external override onlyPresale { diff --git a/contracts/vaults/qubit/QubitPool.sol b/contracts/vaults/qubit/QubitPool.sol index 7ed29b2..a2b4d3c 100644 --- a/contracts/vaults/qubit/QubitPool.sol +++ b/contracts/vaults/qubit/QubitPool.sol @@ -210,7 +210,7 @@ contract QubitPool is BEP20Upgradeable, IQubitPool, RewardsDistributionRecipient require(periodFinish == 0 || block.timestamp > periodFinish, "QubitPool: Not time to set duration"); rewardsDuration = _rewardsDuration; - emit RewardsDurationUpdated(rewardsDuration); + emit RewardsDurationUpdated(_rewardsDuration); } function notifyRewardAmount(uint reward) external override(IQubitPool, RewardsDistributionRecipientUpgradeable) onlyRewardsDistribution { diff --git a/contracts/vaults/qubit/VaultFlipToQBT.sol b/contracts/vaults/qubit/VaultFlipToQBT.sol index 81489e2..a5e964d 100644 --- a/contracts/vaults/qubit/VaultFlipToQBT.sol +++ b/contracts/vaults/qubit/VaultFlipToQBT.sol @@ -234,7 +234,7 @@ contract VaultFlipToQBT is VaultController, IRewardDistributed, RewardsDistribut function setRewardsDuration(uint _rewardsDuration) external onlyOwner { require(periodFinish == 0 || block.timestamp > periodFinish, "VaultFlipToQBT: reward duration can only be updated after the period ends"); rewardsDuration = _rewardsDuration; - emit RewardsDurationUpdated(rewardsDuration); + emit RewardsDurationUpdated(_rewardsDuration); } /* ========== PRIVATE FUNCTIONS ========== */ diff --git a/contracts/vaults/relay/VaultRelayInternal.sol b/contracts/vaults/relay/VaultRelayInternal.sol index a8fa15d..8600860 100644 --- a/contracts/vaults/relay/VaultRelayInternal.sol +++ b/contracts/vaults/relay/VaultRelayInternal.sol @@ -275,7 +275,7 @@ contract VaultRelayInternal is VaultController, IStrategy, RewardsDistributionRe function setRewardsDuration(uint _rewardsDuration) external onlyOwner { require(periodFinish == 0 || block.timestamp > periodFinish, "VaultRelayInternal: reward duration can only be updated after the period ends"); rewardsDuration = _rewardsDuration; - emit RewardsDurationUpdated(rewardsDuration); + emit RewardsDurationUpdated(_rewardsDuration); } function setRelayer(address newRelayer) external onlyOwner {