Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the login process #15

Open
marcdif opened this issue Nov 30, 2020 · 0 comments
Open

Improve the login process #15

marcdif opened this issue Nov 30, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@marcdif
Copy link
Member

marcdif commented Nov 30, 2020

The current login process works, so there's no rush to do this. However, requiring users to allow popups isn't ideal since most browsers block popups by default. We should be able to have a similar flow as other OAuth applications. Clicking the "Sign in with Palace Forums" button would redirect to the https://forums.palace.network/oauth/authorize page. Then, after that page redirects to https://internal-api.palace.network/titan/auth/redirect_uri, that page could automatically redirect back to https://titan.palace.network.

As for where cookies are set, it should be possible to transmit the necessary tokens as headers in the redirect request from internal-api back to titan. This would lead to a specific page in Titan, like https://titan.palace.network/auth/verify. That page then verifies the tokens, and finally sets them as cookies for the domain. Lastly, the user is redirected to the main page.

As I'm writing this, I sort of understand why the current implementation was done first - it's much easier. However, this would allow a more seamless user experience. While it isn't urgent, it should be done at some point.

@marcdif marcdif added the enhancement New feature or request label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants