refactor: clear typeof-guard and assertDefined backlog by andrew-bierman · Pull Request #2312 · PackRat-AI/PackRat

andrew-bierman · 2026-04-26T20:14:33Z

Chained off #2311. Clears the backlog surfaced by the new checks.

Summary

73 typeof violations replaced with @packrat/guards calls (isString, isNumber, isFunction, isObject) across apps/ and packages/
4 assertDefined duplicates collapsed to re-exports from @packrat/guards — existing import paths preserved, no callers updated
no-raw-typeof script now exempts global-availability checks (window, document, globalThis, Bun, navigator, process) which cannot safely be replaced with guards
4 package.json files get @packrat/guards: workspace:* where the package now uses it for the first time (analytics, api-client, cli, config)

After this lands, the two continue-on-error: true lines added in #2311 can be removed — lint:custom and check:casts:strict will both pass clean.

Commits


🔧	Exempt global identifiers from `no-raw-typeof`
♻️	Replace `assertDefined` impls with re-exports
📦	Add `@packrat/guards` dep to 4 packages
♻️	Replace raw typeof in `apps/` (73 violations)
♻️	Replace raw typeof in `packages/` (73 violations)

Test Plan

bun lint:custom passes with 0 violations
bun scripts/lint/no-duplicate-guards.ts passes
bun check (Biome) passes clean — 997 files, 0 errors
Spot-check a few guard replacements: isString, isFunction(ref), isObject w/ null exclusion

coderabbitai · 2026-04-26T20:14:39Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8c5b0d26-6dfb-416d-a1dc-e4bd285890a1

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feat/checks-backlog

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-04-26T20:14:58Z

Coverage Report for API Unit Tests Coverage (./packages/api)

Status	Category	Percentage	Covered / Total
🔵	Lines	74.96%	584 / 779
🔵	Statements	74.96% (🎯 65%)	584 / 779
🔵	Functions	95.91%	47 / 49
🔵	Branches	88.23%	270 / 306

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/api/src/utils/auth.ts	98.93%	90.9%	100%	98.93%	52
packages/api/src/utils/csv-utils.ts	95.06%	87.5%	100%	95.06%	44-45, 47-48, 66-67, 110-111, 127-128, 149-150

Generated in workflow #830 for commit b70286f by the Vitest Coverage Report Action

github-actions · 2026-04-26T20:15:00Z

Coverage Report for Expo Unit Tests Coverage (./apps/expo)

Status	Category	Percentage	Covered / Total
🔵	Lines	81.28%	517 / 636
🔵	Statements	81.28% (🎯 75%)	517 / 636
🔵	Functions	92.85%	52 / 56
🔵	Branches	92.55%	199 / 215

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
apps/expo/lib/utils/dateUtils.ts	0%	0%	0%	0%	1-34
apps/expo/lib/utils/domain-specific-extensions.ts	100%	87.5%	100%	100%

Generated in workflow #830 for commit b70286f by the Vitest Coverage Report Action

cloudflare-workers-and-pages · 2026-04-26T20:15:45Z

Deploying packrat-landing with Cloudflare Pages

Latest commit:	`b70286f`
Status:	✅ Deploy successful!
Preview URL:	https://f389f202.packrat-landing.pages.dev
Branch Preview URL:	https://feat-checks-backlog.packrat-landing.pages.dev

View logs

cloudflare-workers-and-pages · 2026-04-26T20:15:53Z

Deploying packrat-guides with Cloudflare Pages

Latest commit:	`b70286f`
Status:	🚫 Build failed.

View logs

Copilot

Pull request overview

Refactors raw typeof checks and duplicate assertDefined implementations across the monorepo to consistently use @packrat/guards, and updates the custom no-raw-typeof lint to allow safe SSR/global-availability checks.

Changes:

Replaced many typeof-based narrowings with @packrat/guards helpers (isString, isNumber, isFunction, isObject).
Collapsed local assertDefined implementations into re-exports from @packrat/guards.
Updated no-raw-typeof to exempt typeof checks for global availability (window, document, globalThis, Bun, navigator, process) and added @packrat/guards deps where newly required.

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
scripts/lint/no-raw-typeof.ts	Exempts global-availability `typeof` checks while still flagging other raw `typeof` usage.
packages/web-ui/src/lib/utils.ts	Replaces local `assertDefined` with re-export from `@packrat/guards`.
packages/web-ui/src/components/sidebar.tsx	Converts `typeof` string/function checks to `isString`/`isFunction`.
packages/web-ui/src/components/chart.tsx	Converts multiple `typeof` checks to `@packrat/guards` helpers.
packages/config/src/config.ts	Updates deep-freeze object guard to use `isObject`.
packages/config/package.json	Adds `@packrat/guards` dependency.
packages/cli/src/shared.ts	Converts number check to `isNumber`.
packages/cli/src/args.ts	Converts string checks in preprocessors to `isString`.
packages/cli/package.json	Adds `@packrat/guards` dependency.
packages/api/src/utils/env-validation.ts	Uses `isObject` to validate primed env object shape.
packages/api/src/utils/csv-utils.ts	Uses `isString` for FAQ parsing guard.
packages/api/src/utils/auth.ts	Uses `isNumber` for JWT exp handling.
packages/api/src/services/r2-bucket.ts	Replaces raw `typeof` checks with guard helpers, including function/object checks.
packages/api/src/services/etl/CatalogItemValidator.ts	Replaces raw `typeof` validations with `isString`/`isNumber`.
packages/api/src/services/aiService.ts	Uses `isFunction` for optional binding capability detection.
packages/api/src/routes/weather.ts	Uses `isString` for lat/lon parsing.
packages/api/src/routes/catalog/index.ts	Uses `isString` for encoded query param handling.
packages/api/src/routes/ai/index.ts	Uses `isString` for schema result discrimination.
packages/api-client/src/index.ts	Uses `isString`/`isObject` for request input and error body detection.
packages/api-client/package.json	Adds `@packrat/guards` dependency.
packages/analytics/src/core/type-assertions.ts	Replaces local `assertDefined` with re-export from `@packrat/guards`.
packages/analytics/src/core/spec-parser.ts	Uses `isString` in SQL value formatting.
packages/analytics/src/core/entity-resolver.ts	Uses `isString` in SQL value formatting.
packages/analytics/package.json	Adds `@packrat/guards` dependency.
apps/landing/lib/typeAssertions.ts	Re-exports `assertDefined` from `@packrat/guards`.
apps/landing/lib/icons.tsx	Uses `isFunction` for Lucide icon runtime narrowing.
apps/guides/lib/assertDefined.ts	Re-exports `assertDefined` from `@packrat/guards`.
apps/expo/lib/utils/domain-specific-extensions.ts	Uses `isFunction` for extension resolver narrowing.
apps/expo/lib/utils/dateUtils.ts	Uses `isString` for date parsing guard.
apps/expo/features/wildlife/hooks/useWildlifeIdentification.ts	Uses `isObject` for network error classification.
apps/expo/features/trips/components/TripForm.tsx	Uses `isString` for ISO date normalization.
apps/expo/features/packs/components/AddPackItemActions.tsx	Uses `isFunction` for ref shape narrowing before `.current` access.
apps/expo/features/pack-templates/hooks/useGenerateTemplateFromOnlineContent.ts	Uses `isObject` for API error payload extraction.
apps/expo/features/pack-templates/components/AddPackTemplateItemActions.tsx	Uses `isFunction` for ref shape narrowing before `.current` access.
apps/expo/features/ai/lib/localModelManager.ts	Uses `isString` for iOS version parsing.
apps/expo/features/ai/lib/CustomChatTransport.ts	Uses `isString` for error normalization.
apps/expo/features/ai/components/AIModeSheet.tsx	Uses `isFunction` for ref shape narrowing before `.current` access.
apps/expo/features/ai/atoms/chatStorageAtoms.ts	Uses `isObject`/`isString` for persisted chat message validation.
apps/expo/components/initial/WeightBadge.tsx	Uses `isString` to normalize unit.
apps/expo/atoms/atomWithSecureStorage.ts	Uses `isFunction` for updater vs value detection.
apps/expo/atoms/atomWithKvStorage.ts	Uses `isFunction` for updater vs value detection.
apps/expo/atoms/atomWithAsyncStorage.ts	Uses `isFunction` for updater vs value detection.
apps/expo/app/(app)/messages/chat.tsx	Uses `isString` to discriminate date separators vs message objects.
apps/expo/app/(app)/messages/chat.android.tsx	Uses `isString` to discriminate date separators vs message objects.
apps/expo/app/(app)/(tabs)/profile/index.tsx	Uses `isString` to discriminate section headers vs items.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-26T20:20:00Z

-export function assertDefined<T>(val: T | undefined): asserts val is T {
-  if (val === undefined) throw new Error('Value must be defined');
-}
+export { assertDefined } from '@packrat/guards';


This file now re-exports assertDefined from @packrat/guards, but apps/landing/package.json does not declare @packrat/guards as a dependency. Add it (likely "@packrat/guards": "workspace:*") to avoid relying on transitive/hoisted dependencies and to keep the workspace dependency graph accurate.

Suggested change

export { assertDefined } from '@packrat/guards';

export function assertDefined<T>(

value: T,

message = 'Expected value to be defined',

): asserts value is NonNullable<T> {

if (value == null) {

throw new Error(message);

}

}

Copilot · 2026-04-26T20:20:00Z

-export function assertDefined<T>(val: T | undefined): asserts val is T {
-  if (val === undefined) throw new Error('Value must be defined');
-}
+export { assertDefined } from '@packrat/guards';


This file now re-exports assertDefined from @packrat/guards, but apps/guides/package.json does not declare @packrat/guards as a dependency. Add it (likely "@packrat/guards": "workspace:*") so builds don’t depend on hoisting/transitive deps and so dependency tooling remains correct.

window, document, globalThis, Bun, navigator, process are environment/runtime availability checks — accessing them as undeclared globals would ReferenceError, so they cannot be replaced with isDefined() guards.

…ards Four packages had hand-rolled assertDefined that could diverge silently. Converted each to a barrel re-export so existing import paths are preserved but the implementation lives in one place.

analytics, api-client, cli, and config were importing guards for the first time; workspace:* pins them to the monorepo copy.

73 violations cleared across apps/expo, apps/landing, apps/guides: - isString / isNumber / isFunction / isObject from @packrat/guards replace typeof === 'string' / 'number' / 'function' / 'object' - typeof ref !== 'function' (callback-ref pattern) → !isFunction(ref) - typeof item.id === 'string' multi-field guards → isString(item.id) etc.

Covers api, api-client, analytics, cli, config, web-ui: - isString / isNumber / isFunction / isObject replace typeof checks - r2-bucket.ts guard function, CatalogItemValidator, weather routes, chart/sidebar components, env-validation, csv-utils all updated - typeof globalThis (env-validation:127) and typeof Bun (smoke-test) left as-is — covered by the global-identifier exemption in the check

check-all runs strict on everything, which blocks mid-backlog pushes. Gate pre-push only on currently-passing checks; CI still reports the remaining backlog (no-raw-regex, no-raw-process-env, check-type-casts) via continue-on-error. Re-add each here as its backlog clears.

Both apps re-export assertDefined from @packrat/guards but didn't declare the workspace dep — builds relied on transitive hoisting.

refactor: clear typeof-guard and assertDefined backlog

Copilot AI review requested due to automatic review settings April 26, 2026 20:14

github-actions Bot added dependencies Pull requests that update a dependency file api mobile web labels Apr 26, 2026

Copilot started reviewing on behalf of andrew-bierman April 26, 2026 20:15 View session

Copilot AI reviewed Apr 26, 2026

View reviewed changes

andrew-bierman mentioned this pull request Apr 26, 2026

refactor: clear raw-regex and process.env backlogs #2313

Merged

6 tasks

Base automatically changed from feat/improve-custom-checks to development April 26, 2026 21:16

andrew-bierman added 10 commits April 26, 2026 15:27

🔧 exempt global identifiers from no-raw-typeof check

ea31272

window, document, globalThis, Bun, navigator, process are environment/runtime availability checks — accessing them as undeclared globals would ReferenceError, so they cannot be replaced with isDefined() guards.

♻️ replace local assertDefined impls with re-exports from @packrat/gu…

34ddf83

…ards Four packages had hand-rolled assertDefined that could diverge silently. Converted each to a barrel re-export so existing import paths are preserved but the implementation lives in one place.

📦 add @packrat/guards dep to packages that now use it

08f0a17

analytics, api-client, cli, and config were importing guards for the first time; workspace:* pins them to the monorepo copy.

📦 update lockfile for new @packrat/guards workspace deps

68aa1ec

📦 add @packrat/guards dep to landing and guides apps

5ae2f2d

Both apps re-export assertDefined from @packrat/guards but didn't declare the workspace dep — builds relied on transitive hoisting.

🔧 sort apps/guides/package.json after adding @packrat/guards dep

7d46d03

♻️ replace raw typeof in useAuthActions with isObject guard

b70286f

andrew-bierman force-pushed the feat/checks-backlog branch from 210093b to b70286f Compare April 26, 2026 21:30

andrew-bierman merged commit d214645 into development Apr 26, 2026
12 of 15 checks passed

andrew-bierman deleted the feat/checks-backlog branch April 26, 2026 21:46

andrew-bierman added a commit that referenced this pull request May 14, 2026

Merge pull request #2312 from PackRat-AI/feat/checks-backlog

28aecb9

refactor: clear typeof-guard and assertDefined backlog

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: clear typeof-guard and assertDefined backlog#2312

refactor: clear typeof-guard and assertDefined backlog#2312
andrew-bierman merged 10 commits into
developmentfrom
feat/checks-backlog

andrew-bierman commented Apr 26, 2026

Uh oh!

coderabbitai Bot commented Apr 26, 2026 •

edited

Loading

Review skipped

Uh oh!

github-actions Bot commented Apr 26, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 26, 2026 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 26, 2026 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 26, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 26, 2026

Uh oh!

Copilot AI Apr 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-export { assertDefined } from '@packrat/guards';
+export function assertDefined<T>(
+  value: T,
+  message = 'Expected value to be defined',
+): asserts value is NonNullable<T> {
+  if (value == null) {
+    throw new Error(message);
+  }
+}

Conversation

andrew-bierman commented Apr 26, 2026

Summary

Commits

Test Plan

Uh oh!

coderabbitai Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

github-actions Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for API Unit Tests Coverage (./packages/api)

Uh oh!

github-actions Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for Expo Unit Tests Coverage (./apps/expo)

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying packrat-landing with Cloudflare Pages

Uh oh!

cloudflare-workers-and-pages Bot commented Apr 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying packrat-guides with Cloudflare Pages

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Apr 26, 2026 •

edited

Loading

github-actions Bot commented Apr 26, 2026 •

edited

Loading

github-actions Bot commented Apr 26, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Apr 26, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Apr 26, 2026 •

edited

Loading