From d729a7d5579caa57559dd67c15955ca586b7c1b8 Mon Sep 17 00:00:00 2001
From: Chris Wilkinson <c.wilkinson@elifesciences.org>
Date: Mon, 29 Nov 2021 13:11:39 +0000
Subject: [PATCH] lint: remove inferrable types

As the reflect-metadata library is no longer used, we no longer need to define inferrable types.

Refs #422, 58efacb
---
 .eslintrc.json                             | 8 --------
 src/backend/models/entities/Comment.ts     | 4 ++--
 src/backend/models/entities/Event.ts       | 2 +-
 src/backend/models/entities/FullReview.ts  | 4 ++--
 src/backend/models/entities/Persona.ts     | 4 ++--
 src/backend/models/entities/RapidReview.ts | 4 ++--
 src/backend/models/entities/Request.ts     | 2 +-
 src/backend/models/entities/Statement.ts   | 2 +-
 8 files changed, 11 insertions(+), 19 deletions(-)

diff --git a/.eslintrc.json b/.eslintrc.json
index 63f80203..f1c5680d 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -76,14 +76,6 @@
         "node/no-unpublished-import": "off"
       }
     },
-    {
-      "files": [
-        "src/backend/models/entities/**"
-      ],
-      "rules": {
-        "@typescript-eslint/no-inferrable-types": "off"
-      }
-    },
     {
       "files": [
         "integration/**"
diff --git a/src/backend/models/entities/Comment.ts b/src/backend/models/entities/Comment.ts
index 4b817dc2..4186a4c4 100644
--- a/src/backend/models/entities/Comment.ts
+++ b/src/backend/models/entities/Comment.ts
@@ -6,8 +6,8 @@ import { Persona } from './Persona';
 
 export class Comment extends BaseEntity {
   contents!: string;
-  isPublished: boolean = false;
-  isFlagged: boolean = false;
+  isPublished = false;
+  isFlagged = false;
   author!: Persona;
   parent!: FullReview;
 
diff --git a/src/backend/models/entities/Event.ts b/src/backend/models/entities/Event.ts
index 89d49ea1..61a4f559 100644
--- a/src/backend/models/entities/Event.ts
+++ b/src/backend/models/entities/Event.ts
@@ -7,7 +7,7 @@ export class Event extends BaseEntity {
   title!: string;
   start!: Date;
   end?: Date;
-  isPrivate: boolean = false;
+  isPrivate = false;
   description?: string;
   url?: string;
   community?: Community;
diff --git a/src/backend/models/entities/FullReview.ts b/src/backend/models/entities/FullReview.ts
index d6cf96f2..6a9c1072 100644
--- a/src/backend/models/entities/FullReview.ts
+++ b/src/backend/models/entities/FullReview.ts
@@ -8,8 +8,8 @@ import { Preprint } from './Preprint';
 import { Statement } from './Statement';
 
 export class FullReview extends BaseEntity {
-  isPublished: boolean = false;
-  isFlagged: boolean = false;
+  isPublished = false;
+  isFlagged = false;
   doi?: string;
   drafts: Collection<FullReviewDraft> = new Collection<FullReviewDraft>(this);
   mentorInvites: Collection<Persona> = new Collection<Persona>(this);
diff --git a/src/backend/models/entities/Persona.ts b/src/backend/models/entities/Persona.ts
index 84a432de..4806055e 100644
--- a/src/backend/models/entities/Persona.ts
+++ b/src/backend/models/entities/Persona.ts
@@ -13,8 +13,8 @@ export class Persona extends BaseEntity {
   name!: string;
   identity?: User;
   isAnonymous!: boolean;
-  isLocked: boolean = false;
-  isFlagged: boolean = false;
+  isLocked = false;
+  isFlagged = false;
   bio?: string;
   avatar?: Buffer;
   avatar_encoding?: string;
diff --git a/src/backend/models/entities/RapidReview.ts b/src/backend/models/entities/RapidReview.ts
index b2c78c2a..00608e7c 100644
--- a/src/backend/models/entities/RapidReview.ts
+++ b/src/backend/models/entities/RapidReview.ts
@@ -14,8 +14,8 @@ enum Checkboxes {
 export class RapidReview extends BaseEntity {
   author!: Persona;
   preprint!: Preprint;
-  isPublished: boolean = false;
-  isFlagged: boolean = false;
+  isPublished = false;
+  isFlagged = false;
   ynNovel = Checkboxes.na;
   ynFuture = Checkboxes.na;
   ynReproducibility = Checkboxes.na;
diff --git a/src/backend/models/entities/Request.ts b/src/backend/models/entities/Request.ts
index 73741abe..de5084d7 100644
--- a/src/backend/models/entities/Request.ts
+++ b/src/backend/models/entities/Request.ts
@@ -7,7 +7,7 @@ import { Preprint } from './Preprint';
 export class Request extends BaseEntity {
   author!: Persona;
   preprint!: Preprint;
-  isPreprintAuthor: boolean = false;
+  isPreprintAuthor = false;
 
   constructor(author: Persona, preprint: Preprint, isPreprintAuthor = false) {
     super();
diff --git a/src/backend/models/entities/Statement.ts b/src/backend/models/entities/Statement.ts
index 436b26b2..ce1afe79 100644
--- a/src/backend/models/entities/Statement.ts
+++ b/src/backend/models/entities/Statement.ts
@@ -6,7 +6,7 @@ import { Persona } from './Persona';
 
 export class Statement extends BaseEntity {
   contents!: string;
-  isFlagged: boolean = false;
+  isFlagged = false;
   author!: Persona;
   parent!: FullReview;