From 2a5e9810bebe9217971fcec1adbde6a58029e29c Mon Sep 17 00:00:00 2001 From: Chris Wilkinson Date: Tue, 30 Nov 2021 16:19:49 +0000 Subject: [PATCH] fix: hide the add co-reviewer/mentor buttons The 'add co-reviewer(s)' and 'add mentor' buttons don't work correctly and create confusion. As fixing the problem is complicated, this change hides them in favour of manually adding them when requested. Refs #418, #423 --- .../add-form-Desktop-Chrome-linux.png | 4 ++-- .../add-form-iPhone-11-linux.png | 4 ++-- .../draft-Desktop-Chrome-linux.png | 4 ++-- .../draft-iPhone-11-linux.png | 4 ++-- src/frontend/components/review-stepper.js | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/add-form-Desktop-Chrome-linux.png b/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/add-form-Desktop-Chrome-linux.png index 8cf084b1..f1d906e2 100644 --- a/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/add-form-Desktop-Chrome-linux.png +++ b/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/add-form-Desktop-Chrome-linux.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:1476e7c36d05f6716d2f99d88f4d5ec3185f70346d6c8ae450f669567f108f13 -size 97447 +oid sha256:2ed617348c8b38693cc4d4daf2505b2c1a7e7b231ab1b29ba470981aba876ece +size 101981 diff --git a/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/add-form-iPhone-11-linux.png b/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/add-form-iPhone-11-linux.png index ac97cbce..a67a1caf 100644 --- a/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/add-form-iPhone-11-linux.png +++ b/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/add-form-iPhone-11-linux.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:6e350bd9fbbb6753a61f45dcc6b057cf5f9e802d6ba405214de518f99fcd29fa -size 119906 +oid sha256:bc60ef877d8506dea3121cd5be72cd5bf74364102559d9cbdb3a161729bb26c6 +size 124215 diff --git a/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/draft-Desktop-Chrome-linux.png b/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/draft-Desktop-Chrome-linux.png index 9e18c19a..22675ad1 100644 --- a/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/draft-Desktop-Chrome-linux.png +++ b/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/draft-Desktop-Chrome-linux.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:bf2cb34d374bc550c971ea3e6db09167e0a0c7420a6ed071e3df045f990ddeb1 -size 99172 +oid sha256:04c89d979beab3b1eba784ff08f801e9f7f6df792f0ec2066d98b0213491639d +size 105928 diff --git a/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/draft-iPhone-11-linux.png b/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/draft-iPhone-11-linux.png index d5529985..f20d386e 100644 --- a/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/draft-iPhone-11-linux.png +++ b/integration/src/browser/submitting-a-full-review.spec.ts-snapshots/draft-iPhone-11-linux.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:581fa2c9fdeb1a13d1ebc7b8f45026b0401f769757f05dce29d58d9855811e81 -size 128663 +oid sha256:567d9f4fef59790a61fc8df0f85f7c00c265b6061971c8a8fa58a1a39abe668b +size 132667 diff --git a/src/frontend/components/review-stepper.js b/src/frontend/components/review-stepper.js index 1cb43d10..309f3d1d 100644 --- a/src/frontend/components/review-stepper.js +++ b/src/frontend/components/review-stepper.js @@ -726,7 +726,7 @@ export default function ReviewStepper({ )) ) : null} - @@ -734,7 +734,7 @@ export default function ReviewStepper({ isMentor={true} reviewId={cid} authors={review ? review.mentors : null} - /> + />*/}